Skip to content

London | 26-ITP-Sep | Hanna Bohlin | Sprint 1 | formatAs12HourClock #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
habohlin wants to merge 12 commits into
base: main
Choose a base branch
from
+39 −12
Open

London | 26-ITP-Sep | Hanna Bohlin | Sprint 1 | formatAs12HourClock #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
58741a8
Add test to convert noon time, "12:00" (which fails)
habohlin Sep 28, 2026
53b309b
Refactor the previous test funcs to use arrow funcs
habohlin Sep 28, 2026
6e1e485
Add else clause to function to properly format noon time
habohlin Sep 28, 2026
c0c27ea
Add test for time with minutes other than 00, (it fails)
habohlin Sep 28, 2026
99591de
Add possible preceding 0 and exact minutes to times after noon
habohlin Sep 28, 2026
891851b
Add test for morning time complex mins (it passes)
habohlin Sep 28, 2026
8c42ec0
Add test for early noon complex minutes (it passes)
habohlin Sep 28, 2026
72e8b26
Add test for time between midnight and 1 am (it fails)
habohlin Sep 28, 2026
ebfc759
Add else if for when hour = 0, now the final test passes
habohlin Sep 28, 2026
7a51317
Reformatted with prettier
habohlin Sep 28, 2026
2c29789
Rephrase test messages so they are more consistent
habohlin Sep 28, 2026
e231337
Refactor the code to have separate if statements for hours and period…
habohlin Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,25 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(-2);

let period = "";
let hourString = "";

if (hours > 12) {
return `${hours - 12}:00 pm`;
if (hours <= 11){
period = "am";
} else {
period = "pm";
}
return `${time} am`;

if (hours >= 13){
hourString = hours - 12 < 10 ? `0${hours - 12}` : `${hours -12}`;
} else if (hours === 0){
hourString = `${hours + 12}`;

@abdishakoor-dev abdishakoor-dev Oct 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: when hours is 0, what is hours + 12 always going to be? Would writing that value directly make this branch easier to read?

} else {
hourString = hours < 10 ? `0${hours}`:`${hours}`;
}

return `${hourString}:${minutes} ${period}`
}

export {formatAs12HourClock};
export { formatAs12HourClock };
27 changes: 20 additions & 7 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});
test("can format time after 12:00", () =>
assert.equal(formatAs12HourClock("23:00"), "11:00 pm"));

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});
test("can format morning time", () =>
assert.equal(formatAs12HourClock("08:00"), "08:00 am"));

test("can format noon time", () =>
assert.equal(formatAs12HourClock("12:00"), "12:00 pm"));

test("can format afternoon time with minutes other than 00", () =>
assert.equal(formatAs12HourClock("15:45"), "03:45 pm"));

test("can format morning time with minutes other than 00", () =>
assert.equal(formatAs12HourClock("08:25"), "08:25 am"));

test("can format early noon with minutes other than 00", () =>
assert.equal(formatAs12HourClock("12:17"), "12:17 pm"));

test("can format time between midnight and 1 am", () =>

@abdishakoor-dev abdishakoor-dev Oct 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

00:15 checks the midnight hour, but not midnight itself. Which input is the very first minute of the day, which are the last minute before noon and the last minute before midnight, and which is the first time your hours >= 13 branch handles? Those are the places an if on hours is most likely to go wrong, so each is worth its own test.

assert.equal(formatAs12HourClock("00:15"), "12:15 am"));
Loading