London | 26-ITP-May | Bisrat Tesfay | Sprint 2 | Wireframe#1317
London | 26-ITP-May | Bisrat Tesfay | Sprint 2 | Wireframe#1317B3-Bisrat wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
B3-Bisrat
added
📅 Sprint 2
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Code is free or error and well formatted. Good job.
-
To better match the wireframe, can you use a fixed or consistent image height so that article titles across adjacent columns remain horizontally aligned? It's ok to stretch the image dimension.
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> |
There was a problem hiding this comment.
Could you look into why using data URLs for images is generally considered a poor practice?
There was a problem hiding this comment.
Thank you, I looked into it and learned that saving images locally is better practice because it keeps the project self-contained and easier to maintain. It also makes the code cleaner since the file path is much shorter than using a long external image URL.
cjyuan
added
Reviewed
|
Thank you for the feedback. I updated the article images to use a consistent height so the titles in the second and third articles align more closely with the wireframe layout. I used |
B3-Bisrat
added
Needs Review
|
Layout looks good. Would probably look nicer if the images are of the same dimension. |
cjyuan
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
This PR completes the wireframe webpage assignment using semantic HTML and CSS. The page includes three articles about README files, wireframes, and Git branches, each with images, summaries, and links. I also styled the layout to closely match the provided wireframe and ensured the footer stays fixed at the bottom of the page.
Questions