London | 26-ITP-May| Mahdi Rafiei | Sprint 1 | Form Controls#1245
London | 26-ITP-May| Mahdi Rafiei | Sprint 1 | Form Controls#1245mrafeie wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mrafeie
added
Needs Review
Luro91
added
Review in progress
| <label for="size">T-Shirt Size</label> | ||
|
|
||
| <select id="size" name="size"> | ||
| <option value="">Please choose a size</option> |
There was a problem hiding this comment.
What happens when the user would submit the form with this value?
| type="text" | ||
| id="name" | ||
| name="name" | ||
| required | ||
| pattern=".*\S.*\S.*" | ||
| minlength="2" |
There was a problem hiding this comment.
Its good practice to use indentation on the html attributes to make it more readable. How could you ensure consistent and standard formatting of your code?
Luro91
added
Reviewed
mrafeie
added
the
Needs Review
| <select id="size" name="size" required> | ||
| <option value="s">Small</option> | ||
| <option value="m">Medium</option> | ||
| <option value="l">Large</option> | ||
| <option value="xl">XLarge</option> | ||
| <option value="xl">XXLarge</option> | ||
|
|
||
| </select> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>Mahdi Rafiei</p> | ||
| <p>Anita Amirhaeri</p> |
There was a problem hiding this comment.
Why is the code now the same as from Anita Amirhaeri?
There was a problem hiding this comment.
we were working on same laptop and then shared the code. I will fix it in the next commit
Luro91
removed
the
Needs Review
mrafeie
added
the
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
I want to remind you that copying and pasting code, including code generated by AI, is not helpful for learning and should be avoided. The goal of this course is for you to build problem-solving skills through hands-on practice. When working together, you are absolutely welcome to discuss solutions, brainstorm approaches, and collaborate on concepts, but the actual implementation must be written by you.
As a quick self-check before your next submission, ask yourself: "If you deleted all of this code, could you reproduce the solution on your own?" If the answer is uncertain or no, it’s a strong signal that you should take extra time to fully understand and rewrite the logic independently.
To help verify your grasp of the implementation, please also implement something extra to test your understanding:
- Add a required input field for T-shirt quantity, which must be an integer between 1 and 100 (inclusive).
Please make these updates and resubmit your PR
There was a problem hiding this comment.
I see an error on the console when loading the page
Refused to apply style from 'http://127.0.0.1:5500/Form-Controls/style.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
Luro91
removed
the
Needs Review
2 participants
Self checklist
Changelist
added the form as described in the task