Skip to content

Manchester | 26-ITP-Sept | Fatima Rouchi | Sprint 3 | Coursework/sprint 3 - #1634

Open
fatimarouchi wants to merge 24 commits into
CodeYourFuture:mainfrom
fatimarouchi:coursework/sprint-3
Open

fatimarouchi wants to merge 24 commits into
CodeYourFuture:mainfrom
fatimarouchi:coursework/sprint-3

Conversation

@fatimarouchi

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

CYF-1053

@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1d34e47
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ac5010950a0080007829923
😎 Deploy Preview https://deploy-preview-1634--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@fatimarouchi fatimarouchi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 30, 2026

@iscmiguelsamaniego iscmiguelsamaniego left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fantastic work overall across all these exercises! You've shown great progress in fixing scope issues, handling function parameters, working with string methods, and writing robust tests.
As you keep practicing, what strategies do you find most helpful for anticipating edge cases before writing your code?"

Comment thread Sprint-3/1-key-errors/0.js
Comment thread Sprint-3/1-key-errors/1.js
Comment thread Sprint-3/1-key-errors/2.js
Comment thread Sprint-3/2-mandatory-debug/0.js
Comment thread Sprint-3/2-mandatory-debug/1.js
Comment thread Sprint-3/3-mandatory-implement/1-bmi.js
Comment thread Sprint-3/3-mandatory-implement/2-cases.js
Comment thread Sprint-3/3-mandatory-implement/3-to-pounds.js
Comment thread Sprint-3/4-mandatory-interpret/time-format.js
Comment thread Sprint-3/5-stretch-extend/format-time.js
@fatimarouchi fatimarouchi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 2, 2026
@mayowaolokun mayowaolokun added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 2, 2026

@mayowaolokun mayowaolokun left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have clearly understood the main ideas, and your fixes and edge-case tests show good thinking.
I have left a few comments on things to look at again, mainly output formatting, adding more test examples, and how your tests report success. Please read through them, make your changes.

Comment thread Sprint-3/1-key-errors/1.js
Comment thread Sprint-3/3-mandatory-implement/1-bmi.js
Comment thread Sprint-3/3-mandatory-implement/2-cases.js
Comment thread Sprint-3/5-stretch-extend/format-time.js
Comment thread Sprint-3/5-stretch-extend/format-time.js Outdated
@mayowaolokun mayowaolokun added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 2, 2026
@fatimarouchi fatimarouchi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants