Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 3 | coursework - #1610
Open
salahalsabhi wants to merge 11 commits into
Open
salahalsabhi wants to merge 11 commits into
salahalsabhi wants to merge 11 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
salahalsabhi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
salahalsabhi
changed the title
salahalsabhi
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Sep 29, 2026
|
|
||
| // =============> write your explanation here | ||
| // Explanation: A bare return; returns undefined. The expression must be on | ||
| // the same return statement: return a + b; |
There was a problem hiding this comment.
What happens if the expression is above the return statement in a variable? Will it still return or it needs to in the same expression?
Author
There was a problem hiding this comment.
Yes you can store the result in a variable and then return that variable. What failed is a bare return; with no value; any code after that is unreachable.
|
|
||
| function toPounds(penceAmount) { | ||
|
|
||
| const penceStringWithoutTrailingP = String(penceAmount); |
There was a problem hiding this comment.
please review the original code from Spring-2.
The input to the function should be a string.
Author
There was a problem hiding this comment.
Updated — toPounds now accepts a string like "399p", matching Sprint-2.
hey-hammad
added
Reviewed
salahalsabhi
added
the
Needs Review
hey-hammad
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1053