London | 26-ITP-Sep | Chandramani Gaire | Sprint 3 | Sprint 3 coursework by gaireprakash20-ops · Pull Request #1607 · CodeYourFuture/Module-JavaScript-Fundamentals

gaireprakash20-ops · 2026-09-27T11:55:53Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

I am solving some functional problems related to JavaScript.

netlify · 2026-09-27T11:55:59Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`c1bba88`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abd7458e3951e00084a91df
😎 Deploy Preview	https://deploy-preview-1607--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

… height squared to get the BMI. I also used the toFixed method to round the BMI to one decimal place.

…derscores.

…format.js

gaireprakash20-ops

i do as per the instruction

abdishakoor-dev

Your time-format.js answers are all correct, and d) and e) explain why.

Six things before I can mark this Complete:

1-bmi.js: see my comment on line 23.
1-key-errors/1.js: see my comment on line 18.
2-cases.js: see my comment on line 17.
3-to-pounds.js: see my comment on line 7.
2-mandatory-debug/2.js: see my comment on line 29.
Eight of your files fail Prettier. "My code is consistently formatted" is part of the style guide in your PR checklist. Prettier is the tool that does it for you. It formats your code to one agreed style, so a reviewer only sees the changes you meant to make.

Prettier comes with the CYF extension pack from onboarding. If you're not sure you have it, search for CodeYourFuture Extension Pack in VS Code Extensions: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Then open each file you changed, right click, choose Format Document, and pick Prettier if VS Code asks. To format every time you save, follow the steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-29T12:09:20Z

+  const bmi = weight/squared_height;
+  return bmi.toFixed(1);
 }
+console.log(`The BMi of the person is ${calculateBMI(70,2.99)}`);


Your function is correct. The call on this line is not.

Line 5: the person is 1.73m tall.

Line 7: 2.99 is 1.73 x 1.73. So 2.99 is the height squared, not the height.

Your function already squares the height on line 19.

So when you pass 2.99, it is squared twice. That is why you get 7.8.

Please pass the height, 1.73, instead of 2.99. Line 9 says the answer should then be 23.4. Update your comment on line 24 too.

I put the value 1.73 instead of 2.99 and update the comment on line24.

Fixed now. 23.4 is right. Good.

abdishakoor-dev · 2026-09-29T12:09:20Z


 // =============> write your explanation here
-
+// while running this function is shows typeerror because decimal number variable is declared two times.


Your fixed code is correct. Only the error name on this line is wrong.

Line 18 says TypeError. But the original code gives a SyntaxError. The name decimalNumber is declared two times, and JavaScript does not allow that.

Please change "typeerror" on line 18 to "SyntaxError".

i make a small correction type error into syntax error.

That's the one. Good.

abdishakoor-dev · 2026-09-29T12:09:20Z

 // You will need to come up with an appropriate name for the function
 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+function touppercase(str){


Your function works. It gives HELLO_THERE. Only the name needs to change.

The name should say what the function does:

touppercase says: make the letters capital. That is only half of the job.

Your function also changes spaces to _. Line 4 calls this UPPER_SNAKE_CASE.

So a better name is toUpperSnakeCase.

Also, in JavaScript we write a name with more than one word like this: the first word is small, and each new word starts with a capital letter. For example, toUpperCase, not touppercase. This is called camelCase.

Please rename the function, and the call on line 20.

change the function name from touppercase into toUpperSnakeCase.

toUpperSnakeCase is the one. Good.

abdishakoor-dev · 2026-09-29T12:09:21Z

 // You will need to declare a function called toPounds with an appropriately named parameter.

 // You should call this function a number of times to check it works for different inputs
+function toPound(penceString) {


Line 4 asks for a function called toPounds, with an s at the end. Your function is toPound, with no s. Please rename it, and the calls on lines 22 and 23.

as per the instruction i changed the function name topounds from topound.

Fixed now. Good.

abdishakoor-dev · 2026-09-29T12:09:21Z

+// In this variable num is constant and there is no any declaration in function name. Due to this reasons result always be 3.
 // Finally, correct the code to fix the problem
 // =============> write your new code here
+const num = 103;


Your function on line 31 has its own num parameter. So is the num on line 29 used? If not, please remove it.

i comment the line 29 but does not removed it. for reading its should be easy

The original code on line 9 already shows const num = 103; for reading. Line 29 is part of your new code, and your new code does not need it at all.

The CYF style guide, which you ticked in your PR checklist, says:

Once you have solved the problem, you should remove large sections of commented out code. When you (or someone else) are reading your code, you want to know only the important pieces.

https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/

Please delete line 29.

Fixed now. Good.

…e console log to reflect the new function name

abdishakoor-dev

Thanks for the fixes. The BMI call, the SyntaxError answer and both function names are all right now.

Two things before I can mark this Complete:

2-mandatory-debug/2.js line 29: see my reply there.
Eight of your files still fail Prettier, the same as last time. Please do these steps for each file you changed:
- Open the file in VS Code.
- Right click in the file, and choose Format Document.
- If VS Code asks which formatter to use, choose Prettier.
- Save the file.
If you don't see Prettier, install the CodeYourFuture Extension Pack first: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

To have Prettier do this every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

gaireprakash20-ops

Remove the line 29 and formatted Prettier.

abdishakoor-dev

Thanks. Line 29 is gone now. Good.

One thing is left before I can mark this Complete. The same eight files still fail Prettier. Your last commit only changed 2-mandatory-debug/2.js. So the formatting did not reach GitHub.

Please try this with one file first, 2-cases.js:

Open it in VS Code.
Right click in the file, and choose Format Document.
On line 18, the single quotes ' ' and '_' should change to double quotes. If nothing changes, Prettier is not running. Install the CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack
Save the file. It now shows in Source Control with an M.

Then do the same for the other seven files. Commit and push.

Add the Needs Review label again once you've pushed.

gaireprakash20-ops

last of change and Prettier file Formatting

first prediction

c6a44f1

gaireprakash20-ops added 11 commits September 27, 2026 13:13

o.js has been fixed and output is Ramesh

161d044

predict to write return in line 6

e09336a

Put return instead of console.log

ffcaf92

change and finally got the error fixed

370f927

Predict and put the num inside the get last digit function

450b81e

Delete and cons and put convertToPercentage function back in the code

2cb2539

change the function assigning the variable num .

36a8256

In this , i make the height squared and then divide the weight by the…

ccccc5a

… height squared to get the BMI. I also used the toFixed method to round the BMI to one decimal place.

Lower case is changed into upper case and spaces are replaced with un…

7c0c3df

…derscores.

make a function to convert pence to pounds

cac70ad

give a answer to the question in the file 4-mandatory-interpret/time-…

9dcb6ac

…format.js

gaireprakash20-ops commented Sep 27, 2026

View reviewed changes

gaireprakash20-ops added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 27, 2026

abdishakoor-dev reviewed Sep 29, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 29, 2026

gaireprakash20-ops added 5 commits September 29, 2026 22:41

update the height of the person 1.73 and update the comment 24

9e097c2

make atype error into syntex errorans soon.

dff88a2

replace function name touppercase with toUpperSnakeCase

87ff7d9

i changed the function name topounds from topound and also changed th…

6cdfd03

…e console log to reflect the new function name

i comment the line 29 not removed.

992bd50

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 29, 2026

abdishakoor-dev reviewed Sep 30, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 30, 2026

Removed the line 29

3a7d287

gaireprakash20-ops commented Sep 30, 2026

View reviewed changes

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 30, 2026

abdishakoor-dev reviewed Sep 30, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 30, 2026

last commit by take out of

c1bba88

gaireprakash20-ops commented Sep 30, 2026

View reviewed changes

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 30, 2026


		// =============> write your explanation here

		// while running this function is shows typeerror because decimal number variable is declared two times.

Uh oh!

Conversation

gaireprakash20-ops commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Changelist

Uh oh!

netlify Bot commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

gaireprakash20-ops left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

gaireprakash20-ops left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

gaireprakash20-ops left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaireprakash20-ops commented Sep 27, 2026 •

edited

Loading

netlify Bot commented Sep 27, 2026 •

edited

Loading