Repository navigation
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Yama948
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Yama948
changed the title
Yama948
force-pushed
the
feature/form-controls
branch
from
September 25, 2026 22:38
4b1b82b to
b41a825
Compare
Yama948
added
the
Needs Review
cjyuan
reviewed
Sep 29, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
Code looks good.
-
The PR description is not properly formatted in Markdown syntax. Could you address this issue?
-
Could you increase the Lighthouse accessibility score to 100?
cjyuan
added
Reviewed
Yama948
added
Needs Review
cjyuan
reviewed
Oct 7, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you include Task Code and Changelist sections in the PR description, and format them using the same structure as this PR?
#1544
If you'd like to make your "Changelist" section more professional, consider asking AI: "What should be included in the Changelist section of a PR?"
Comment on lines
+60
to
66
| <footer> | ||
| <!-- Submit Button --> | ||
| <button type="submit">Place Order</button> | ||
| </form> | ||
| </main> | ||
| </footer> | ||
| </body> |
Contributor
There was a problem hiding this comment.
Indentation is off.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
CYF-1004: Complete form controls