London | 26 ITP SEP | Russom Gebremeskel | Sprint 3 | Coursework

[russom-g]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1053

Changelist

Code error fixed, debugged, and refactored as reqiured.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	e2a9087
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abd65868f672900082e4bff
😎 Deploy Preview	https://deploy-preview-1520--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[abdishakoor-dev]

1-key-errors/1.js and 2.js are both fixed, thanks.

Four things before I can mark this Complete:

1. 3-to-pounds.js has not changed yet. See my reply on line 8.
2. time-format.js d) and e): see my reply on line 44.
3. In 1-key-errors, the original code still runs. See my comment on 0.js line 23.
4. Most of your files still fail Prettier. Prettier is the tool that formats your code to one agreed style. It comes with the CYF extension pack from onboarding. If you're not sure you have it, search for CodeYourFuture Extension Pack in VS Code Extensions: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack Then open each file you changed, right click, choose Format Document, and pick Prettier if VS Code asks. Do item 3 first. Prettier cannot read 2.js while square(3) is still live. To format every time you save, follow the steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

[abdishakoor-dev]

Run this file with node. What happens? The original code on lines 11 to 14 still runs. It stops the file with a SyntaxError, so your fix never runs. How can you keep the original in the file but stop it running? 1.js and 2.js have the same problem.

[russom-g]

Commented out code in 0.js, 1.js, and 2.js to stop error throwing.

[abdishakoor-dev]

Fixed now. All three files run without an error.

[russom-g]

@abdishakoor-dev I believe I fixed all the issues. Thanks for the feed back. It's much appreciated .

[abdishakoor-dev]

Thanks Russom. Items 1 to 3 from my last review are done.

One thing is left before I can mark this Complete. Nine of your Sprint-3 files still fail Prettier. This is the third time I have asked. Last time, Prettier could not read 2.js. Now it can.

Open each file you changed, right click, and choose Format Document. Save and push. To format every time you save, follow the steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

[russom-g]

@abdishakoor-dev I thought I already had formatted all the code. All is done now. Thanks

[abdishakoor-dev]

Thanks Russom. All your files pass Prettier now, and every file runs without an error.

Marking this Complete. Well done.