Skip to content

Cape Town | 25-ITP-MAY | Asanda Dunn | Sprint 2 | Book Library - #592

Open
asandagwala wants to merge 1 commit into
CodeYourFuture:mainfrom
asandagwala:book-library-debugging
Open

asandagwala wants to merge 1 commit into
CodeYourFuture:mainfrom
asandagwala:book-library-debugging

Conversation

@asandagwala

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1122

Changelist

  • Fixed the syntax error in the for loop used to remove old table rows.
  • Fixed the book array reference from library to myLibrary.
  • Fixed the author field so the book uses the entered author instead of the title.
  • Added validation for the author field when adding a book.
  • Fixed the Read/Unread status so it correctly displays Yes when a book has been read and No when it hasn't.
  • Fixed the delete button variable from delBut to delButton.
  • Fixed the delete button event listener from "clicks" to "click".
  • Fixed the delete button so it correctly removes the selected book from the library.

@asandagwala asandagwala added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 29, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants