Address critical npm vulnerabilities in builder frontend - #495
Open
prestoncabe wants to merge 2 commits into
Open
Address critical npm vulnerabilities in builder frontend#495prestoncabe wants to merge 2 commits into
prestoncabe wants to merge 2 commits into
Conversation
The previous commit resolved the fast-xml-parser critical advisory (GHSA affecting <=5.6.0) by bumping it 5.2.5 -> 5.11.1. That works, but 5.11 decomposed the library, so the bump pulled six brand-new runtime packages into the shipped production graph: @nodable/entities, fast-xml-builder, is-unsafe, path-expression-matcher, xml-naming, and anynum via strnum. Nothing in the repo imports it. A search for fast-xml-parser, XMLParser, XMLBuilder, and XMLValidator finds no hits outside the package.json entry itself, so the upgrade expanded the production supply-chain surface by seven packages in exchange for no functionality. Remove the dependency and re-lock instead. This clears the same advisory and drops the whole subtree. Verified on devbox's Node 22.23.2: `npm ci` clean, `npm audit` reports 0 vulnerabilities, `npm test` 35/35 pass, and `npm run build` succeeds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W8h2QpmBtXzzVBUcJQydrR
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast-xml-parserdependencyCritical findings reviewed
fast-xml-parser5.2.5protobufjs7.5.3firebase→@firebase/firestore→@grpc/proto-loader→protobufjsseroval1.3.2solid-js→serovaltar7.4.3@tailwindcss/postcss→@tailwindcss/oxide→tarwebsocket-driver0.7.4firebase→@firebase/database→faye-websocket→websocket-driverThe associated high, moderate, and low findings were also resolved by the same lockfile refresh, so no follow-up vulnerability issues are needed.
Validation
npm cinpm audit— 0 vulnerabilitiesnpm test— 35 tests passednpm run buildCloses #492