mctp-linux: Use sendmsg() with iovecs instead of concatenating buffers#55
Merged
Conversation
send_vectored() previously concatenated the caller's buffers into a allocated Vec before passing it to sendto(). This copied the entire message payload on every send. Add MctpSocket::io_sendmsg() (and an async MctpSocketAsync::sendmsg() wrapper) that builds an iovec array referencing the caller's buffers directly and passes it to sendmsg(). All four send_vectored() implementations (MctpLinuxReq, MctpLinuxAsyncReq, MctpLinuxResp, MctpLinuxAsyncResp) are updated to use the new path, resolving the existing "implement sendmsg() with iovecs" TODOs. Signed-off-by: Nathan Jian <nathan.jian7@gmail.com>
Member
|
Thanks! Out of curiosity, did you notice the old path being slow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_vectored() previously concatenated the caller's buffers into an allocated Vec before passing it to sendto().
This copied the entire message payload on every send.
Add MctpSocket::io_sendmsg() (and an async MctpSocketAsync::sendmsg() wrapper) that builds an iovec array
referencing the caller's buffers directly and passes it to sendmsg().
All four send_vectored() implementations (MctpLinuxReq, MctpLinuxAsyncReq, MctpLinuxResp,
MctpLinuxAsyncResp) are updated to use the new path, resolving the existing "implement sendmsg()
with iovecs" TODOs.