200 project card#207
Open
mehanana wants to merge 3 commits into
Open
Conversation
tsudhakar87
requested changes
May 12, 2026
Contributor
tsudhakar87
left a comment
tsudhakar87
left a comment
There was a problem hiding this comment.
looks solid! just some minor things I noticed when testing locally
| <RxPeople /> | ||
| <h5 className="!font-bold">Staff</h5> | ||
| </div> | ||
| <p className="truncate">{members} members</p> |
Contributor
There was a problem hiding this comment.
(nit) should this also be members.toLocaleString()?
| <div className="w-full !h-[24px] rounded-full bg-black-100"> | ||
| <div className={`w-[${percentage}%] !h-full rounded-full bg-core-green`} /> | ||
| </div> | ||
| <p>30%</p> |
Contributor
There was a problem hiding this comment.
is this meant to be hardcoded (?) (can replace w {percentage}%)
| </div> | ||
| <div className="flex flex-row items-center !gap-2"> | ||
| <div className="w-full !h-[24px] rounded-full bg-black-100"> | ||
| <div className={`w-[${percentage}%] !h-full rounded-full bg-core-green`} /> |
Contributor
There was a problem hiding this comment.
I think this isn't applying the percentage to the class bc it's interpreting it as a template literal and can't determine the value, so you could add it as separate styling via <div style={{ width: `${percentage}%`` }} className="!h-full rounded-full bg-core-green" /> so that it adjusts the progress bar width properly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
#200
📝 Description
Created project card components for both active and archived project cards
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!