client: pass full Query to SendQuery in BeginInsert (preserve query_id)#517
Merged
Conversation
BeginInsert(Query) was calling SendQuery(query.GetText()). This dropped any caller-supplied query_id (the string constructor has empty default). Pass the Query object directly so the id (and settings etc.) are preserved on the wire. The one-shot Insert path already did the right thing.
iliaal
force-pushed
the
begininsert-queryid
branch
from
65f0776 to
52bd2c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeginInsert(Query query) was calling SendQuery(query.GetText()).
The implicit Query(string) constructor uses an empty default query id, so any query_id the caller supplied was silently dropped. The INSERT would land in system.query_log with an auto-generated id.
Pass the full Query object (the one-shot Insert path already did this).
This was originally carried as a local patch and is exercised by real usage that cares about stable query ids for auditing.