Skip to content

client: clear Inserting state before connect in ResetConnection #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

client: clear Inserting state before connect in ResetConnection #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clickhouse/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,13 @@ void Client::Impl::Ping() {
}

void Client::Impl::ResetConnection() {
// Clear the insert state BEFORE attempting to reconnect. If connect()
// throws (server at max_connections, ephemeral-port exhaustion, DNS blip,
// etc. — all cases where the original dirty socket may still be healthy),
// a still-Inserting state would make ~Impl's automatic EndInsert() fire
// on the old dirty wire and commit a partially-streamed insert.
state_ = State::Idle;

InitializeStreams(socket_factory_->connect(options_, current_endpoint_.value()));
state_ = State::Idle;

Expand Down
Loading