[ENG-10338] Registrations not becoming public when embargo ends: follow-up fix#11748
Conversation
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Looks good overall, there is some issue with my local admin app, so I merged into a temporary branch https://github.com/CenterForOpenScience/osf.io/tree/feature/hotfix-cr-test for me to test it.
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Left a few questions and suggestions @antkryt .
In addition, have you tested all three lists with pagination locally (not unit tests)? If not, please test it. You can tweak your pagination size to a lower value like 3 so you have less data to create.
If for some limitation, you can't test it locally or you can only test some of them, please document them.
(Note: the ticket is currently assigned to QA for creating registrations/embargoes on staging2.)
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
⭐ Ready to go and 👍 for the responses.
Note: hold the merge until we next hotfix branch is available for us; but will put this on a temporary branch on staging2.
cslzchen
changed the title
cslzchen
merged commit ad46ed1
into
CenterForOpenScience:hotfix/26.10.2
2 participants
Ticket
Purpose
optimize embargo report
(Added by @cslzchen ) Here is the initial PR that implements the embargo report feature: #11637
Changes
Side Effects
QE Notes
CE Notes
Documentation