Skip to content

Support decision point display value search in experiment filters#3225

Open
zackcl wants to merge 2 commits into
devfrom
feature/3224-decision-point-display-search
Open

Support decision point display value search in experiment filters#3225
zackcl wants to merge 2 commits into
devfrom
feature/3224-decision-point-display-search

Conversation

@zackcl

@zackcl zackcl commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Resolves #3224

Changes:

  • Allow Experiment list Decision Point searches to match the displayed site (target) format
  • Preserve existing site-only and target-only matching
  • Include the same decision point display matching in global search

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves #3224 by extending experiment list search filtering so Decision Point queries can match the displayed site (target) format (while keeping the existing site-only and target-only matching), and by applying the same behavior to global (“all”) search.

Changes:

  • Add a decision-point “display value” search clause: site when target is empty, otherwise CONCAT(site, ' (', target, ')').
  • Reuse the same decision-point search logic for both DECISION_POINT filtering and ALL search.
  • Add unit tests covering the generated SQL clauses and update the paginated endpoint Swagger enum values.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/backend/src/api/services/ExperimentService.ts Adds the combined decision-point display search clause and factors decision-point search terms into a shared helper.
packages/backend/test/unit/services/ExperimentService.test.ts Adds unit tests verifying decision-point and all-search include the new display-value matching clause.
packages/backend/src/api/controllers/ExperimentController.ts Updates Swagger docs to include additional supported search keys (context, id, decisionPoint).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/backend/src/api/services/ExperimentService.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experiment list Decision Point filter does not match displayed site (target) value

3 participants