feat: add cookies and gamma correction to headlights - #68
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client-side persistence and a perceptual brightness mapping to the Headlight control UI so headlight settings survive refreshes and publish adjusted PWM values to ROS topics.
Changes:
- Persist left/right slider values in cookies with a 1-day max-age and restore them on mount.
- Apply gamma correction when publishing slider values to
/left_headlightand/right_headlight. - Gate publishing and UI enablement on
cookiesLoadedto avoid publishing defaults before cookie restore.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+38
to
+44
| const perceivedBrightnessToPWM = (brightness: number) => { | ||
| const normalizedBrightness = clampBrightness(brightness) / 100; | ||
|
|
||
| return Math.round( | ||
| Math.pow(normalizedBrightness, BRIGHTNESS_GAMMA) * 100 | ||
| ); | ||
| }; |
ConnorNeed
force-pushed
the
headlight-fixes
branch
from
August 2, 2026 17:30
b69230b to
457b2f9
Compare
codeflight1
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the headlight number persistent for 1 day so refreshing doesn't turn off the headlights