fix harvester document type splitting#855
Open
TahaKhan998 wants to merge 1 commit into
Open
Conversation
kpsherva
reviewed
Jul 16, 2026
| return [ | ||
| ParentMatchFilter( | ||
| value=cdsrdm_id, | ||
| query=[dsl.Q("term", **{"parent.id": cdsrdm_id})], |
Contributor
There was a problem hiding this comment.
I think the point was to also contain the query inside the respective filter class, so that we simplify the code here
Author
There was a problem hiding this comment.
I’ve moved each query into its respective filter class
TahaKhan998
force-pushed
the
fix/issue-849-document-type-splitter-feedback
branch
from
July 17, 2026 08:01
70370e5 to
f65e0ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #849, covering the Logic checks and tests section. This prevents duplicate versions when multiple INSPIRE document types map to the same CDS-RDM resource type, adds a regression test for that case, removes the unused _PREPRINT_DOC_TYPES constant, and reorganizes the record-matching filters into named dataclasses without changing their behavior or priority.