fix harvester conflict handling#854
Merged
kpsherva merged 1 commit intoJul 15, 2026
Merged
Conversation
TahaKhan998
force-pushed
the
feat/issue-846-harvester-inspire-source-of-truth
branch
from
July 15, 2026 09:15
eab429e to
386dcb0
Compare
kpsherva
reviewed
Jul 15, 2026
| "metadata.identifiers": IdentifiersFieldUpdate(), | ||
| "metadata.related_identifiers": RelatedIdentifiersUpdate(), | ||
| "metadata.publication_date": PublicationDateUpdate(), | ||
| "metadata.publication_date": PublicationDateUpdate( |
Contributor
There was a problem hiding this comment.
wouldn't it be easier to use OverwriteFieldUpdate, instead of creating a new argument?
Author
There was a problem hiding this comment.
Good point, I changed this to use OverwriteFieldUpdate and removed the new argument.
kpsherva
reviewed
Jul 15, 2026
| } | ||
|
|
||
|
|
||
| CDS_DOI_UPDATE_STRATEGY_CONFIG = { |
Contributor
There was a problem hiding this comment.
this name confused me a little bit - I would suggest changing it to something more descriptive
Suggested change
| CDS_DOI_UPDATE_STRATEGY_CONFIG = { | |
| CDS_ORIGINAL_RECORD_UPDATE_STRATEGY_CONFIG = { |
Author
There was a problem hiding this comment.
Agreed, I renamed it to CDS_ORIGINAL_RECORD_UPDATE_STRATEGY_CONFIG.
TahaKhan998
force-pushed
the
feat/issue-846-harvester-inspire-source-of-truth
branch
from
July 15, 2026 14:26
386dcb0 to
55a9af7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #846
This change reduces false harvester conflicts by treating INSPIRE as the source of truth for valid publication date differences. For regular records, the incoming INSPIRE publication date is now applied automatically instead of requiring manual conflict resolution. Records with a CDS-managed DOI remain on the existing strict conflict path because CDS is authoritative for those records. Genuine transformation failures and other update conflicts continue to be reported as errors.
Tests cover both regular records and CDS-DOI records to verify the two policies behave as expected.