Skip to content

Refactor the service layer#78

Closed
BytecodeBrewer wants to merge 5 commits into
mainfrom
refactor-the-service-layer
Closed

Refactor the service layer#78
BytecodeBrewer wants to merge 5 commits into
mainfrom
refactor-the-service-layer

Conversation

@BytecodeBrewer

Copy link
Copy Markdown
Owner

What changed?

  • dissolve calculator and conversion service
  • update exchange clients test

Related issue

Closes #71

Tests

  • I ran pytest
  • Existing tests pass
  • I added or updated tests where necessary
  • Not needed because this only affects documentation or repository setup

Checklist

  • The change is focused
  • No secrets or API keys are included
  • Documentation was updated if needed
  • CI is expected to pass

Notes

  • methods from previosly conversion service aren't tested yet -> before the sprint 3 starts and CD Pipleline is going o be implemented, its need to be done.

@BytecodeBrewer BytecodeBrewer linked an issue Jul 7, 2026 that may be closed by this pull request
5 tasks

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17cfee10c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/legacy/services/conversion_service.py
Comment thread src/argus/gui/app.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor the service layer

1 participant