Repository navigation
fix: Improve dialog close handling - #7614
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
reviewed
Oct 14, 2026
|
|
||
| // If the dialog is disconnected before the close animation finishes | ||
| if (this.opened) { | ||
| if (!this.#closeHandled) { |
Member
There was a problem hiding this comment.
Is there a way to unit test this?
GZolla
commented
Oct 14, 2026
| expect(elem.opened).to.be.false; | ||
| expect(document.body.style.overflow).to.equal(''); | ||
| }); | ||
| it(`should re-enable body scrolling when closed and disconnected${useNative ? ' for native dialogs' : ''}`, async() => { |
Contributor
Author
There was a problem hiding this comment.
This test fails on main when using native dialogs
|
🎉 This PR is included in version 3.331.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-10785
If a dialog is closed and immediately disconnected(i.e. a parent component is removed while listening to an event dispatched from the same operation as the closure). Then the dialog is never re-rendered, the native dialog does not close and the handler does not run. The disconnected callback check is also ignored since the dialog is closed as it was disconnected.
This means that in that scenario the handler never runs and the body cannot be scrolled. So this PR changes the disconnected callback check so it ensures the handler is always run after a dialog is opened, be that it's closed or disconnected.