Feature: Remote desktop additional shortcuts#3500
Merged
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Owner
Author
|
Wake up @copilot - how about a code review? |
Contributor
Here's the code review for this PR: Overall: ✅ Clean implementation, no bugs found. What looks good
Minor observations (no action needed)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request adds support for sending additional common Windows keyboard shortcuts to remote desktop sessions, making it easier for users to perform actions like opening Task Manager, locking the session, and more. The changes introduce new keystroke options, update the UI to include these shortcuts in context menus, and enhance documentation to describe the new features.
Remote Desktop Keyboard Shortcut Enhancements:
Keystrokeenum: Task Manager (Ctrl+Shift+Esc), Lock (Win+L), Show Desktop (Win+D), Explorer (Win+E), and Run Dialog (Win+R). (Keystroke.cs)RemoteDesktop.GetKeystrokeand updated theSendKeymethod to support them. (RemoteDesktop.cs,RemoteDesktopControl.xaml.cs) [1] [2]UI and Command Updates:
DragablzTabHostWindow.xamlandRemoteDesktopHostView.xamlto provide menu items for the new keyboard shortcuts, each bound to a corresponding command. [1] [2]ICommandproperties and refactored command handling in the code-behind and view models to support the new shortcuts, using a unified method for sending keystrokes. (DragablzTabHostWindow.xaml.cs,RemoteDesktopHostViewModel.cs) [1] [2]Localization and Documentation:
Strings.resxand exposed them inStrings.Designer.cs. [1] [2]remote-desktop.md) [1] [2]To-Do
Contributing
By submitting this pull request, I confirm the following: