Multi-stream follow-up: simplify UI and fix lifecycle bugs - #11
Draft
BlueCheeseburger wants to merge 10000 commits into
Draft
Multi-stream follow-up: simplify UI and fix lifecycle bugs#11BlueCheeseburger wants to merge 10000 commits into
BlueCheeseburger wants to merge 10000 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged multi-stream feature (#1). Contains UI cleanup and bug fixes found during testing.
UI simplification
Lifecycle bug fixes (found in bug testing)
StreamingStop()— the signal callback fired when the primary output stops for any reason — now tears down the secondary streams. Previously only the manual stop path did, so a primary disconnect/error left Twitch/TikTok broadcasting and could crash on a laterResetOutputs()via dangling encoder references.Start()now defensively stops existing outputs first, avoiding orphaning a running output on the reconnect re-entry path.obs_shutdown(), since they share the primary handler's encoders.Verified correct (not bugs)
operator=takes ownership; no leaks or double-frees).uivalid XMLTest plan
https://claude.ai/code/session_01L3WhNDVEXb2TatcruuniCp
Generated by Claude Code