Conversation
Ticket: WCI-626 EdDSA MPCv2 signing can receive multiple BitGo-to-signer shares in a txRequest. Selecting only by sender/recipient can pick a stale round-1 output during round 2. - Add shareType param to getBitgoSignatureShare to filter by round output type. - Update EdDSA MPCv2 callers to request round-1 or round-2 output explicitly. - Remove inline reverse().find() in offline round-3 path in favour of the helper. - Update tests to expect round-specific missing share error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EdDSA MPCv2 signing can receive multiple BitGo-to-signer shares in a txRequest.
Selecting only by sender/recipient can pick a stale round-1 output during round 2.
Ticket: WCI-626