feat(sdk-core): add wallet.defi DeFi vault orchestration methods#8912
Draft
hitansh-madan wants to merge 1 commit into
Draft
feat(sdk-core): add wallet.defi DeFi vault orchestration methods#8912hitansh-madan wants to merge 1 commit into
hitansh-madan wants to merge 1 commit into
Conversation
hitansh-madan
force-pushed
the
feat/sdk-defi-vault-methods
branch
2 times, most recently
from
a86ee1d to
065e0e5
Compare
Add SDK-side orchestration for Galaxy × Morpho ERC-4626 vault deposits. Introduces wallet.defi.depositToVault() which sequences approve + deposit txRequests with fail-fast auto-cancel, plus resumeDeposit() for recovery, and getOperation()/listOperations() for status tracking. Ticket: CGD-1533 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hitansh-madan
force-pushed
the
feat/sdk-defi-vault-methods
branch
from
065e0e5 to
ef017e9
Compare
Comment on lines
+107
to
+112
| try { | ||
| await this.cancelTxRequest(approveTxRequestId); | ||
| } catch { | ||
| // Best-effort cancel; the reconciler will clean up if this fails | ||
| } | ||
| throw err; |
Contributor
There was a problem hiding this comment.
thoughts on this?
Suggested change
| try { | |
| await this.cancelTxRequest(approveTxRequestId); | |
| } catch { | |
| // Best-effort cancel; the reconciler will clean up if this fails | |
| } | |
| throw err; | |
| await this.cancelTxRequest(approveTxRequestId); |
Comment on lines
+224
to
+225
| private operationUrl(operationId: string): string { | ||
| return `/api/defi-service/v1/operations/${operationId}`; |
Contributor
There was a problem hiding this comment.
I think this endpoint should also be be wallet.
without wallet scope, in the resumeDeposit() flow, it can potentially fetch operation from foreign wallet.
Suggested change
| private operationUrl(operationId: string): string { | |
| return `/api/defi-service/v1/operations/${operationId}`; | |
| private operationUrl(operationId: string): string { | |
| return `/api/defi-service/v1/wallets/${this.wallet.id()}/operations/${operationId}`; |
Comment on lines
+87
to
+89
| if (!operationId) { | ||
| throw new Error('operationId not found in approve txRequest response'); | ||
| } |
Contributor
There was a problem hiding this comment.
should we do cleanup if the operationId is not present in the response?
| } | ||
|
|
||
| private async cancelTxRequest(txRequestId: string): Promise<void> { | ||
| await this.bitgo.del(this.bitgo.url('/wallet/' + this.wallet.id() + '/txrequests/' + txRequestId, 2)).result(); |
Contributor
There was a problem hiding this comment.
does this endpoint exist today in platform?
DELETE /txrequests/{id}
Comment on lines
+192
to
+205
| const query: Record<string, string | number> = { | ||
| walletId: this.wallet.id(), | ||
| vaultId: params.vaultId, | ||
| }; | ||
| if (params.state) query.state = params.state; | ||
| if (params.type) query.type = params.type; | ||
| if (params.limit) query.limit = params.limit; | ||
| if (params.cursor) query.cursor = params.cursor; | ||
|
|
||
| return await this.bitgo | ||
| .get(this.bitgo.microservicesUrl(this.vaultOperationsUrl(params.vaultId))) | ||
| .query(query) | ||
| .result(); | ||
| } |
Contributor
There was a problem hiding this comment.
vaultId redundant in the request
It's present in both URL path and query string.
| ...(params.clientIdempotencyKey ? { clientIdempotencyKey: params.clientIdempotencyKey } : {}), | ||
| }; | ||
|
|
||
| const approveTxRequest = await this.createTxRequest(approveIntent); |
Contributor
There was a problem hiding this comment.
instead of using createTxRequest can we use the sendMany() method?
tomorrow, if we need to extend the depositToVault() for hot wallets, it will be easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SDK-side orchestration for Galaxy × Morpho ERC-4626 vault deposits. Introduces wallet.defi.depositToVault() which sequences approve + deposit txRequests with fail-fast auto-cancel, plus resumeDeposit() for recovery, and getOperation()/listOperations() for status tracking.
Ticket: CGD-1533