feat: re-add the Crowdfund standard (SDK) - #266
Merged
Conversation
Revert of eb87fe7 (#248). The standard was removed because the chain's inclusive 0.1% protocol fee taxed the mint-escrow deposit leg, so a fully-funded crowdfund could never withdraw/refund (funds stuck). The chain is moving to an additive protocol-fee model in v33 (recipient/escrow receives the full quoted amount, fee charged on top), which unblocks crowdfund withdraw/refund — so the standard is restored. Restores core/crowdfunds.ts + builders/crowdfund.ts, builder preset, CLI `crowdfunds` command surface, agent skill, verifier, standards-info, design-decision + review-ux registry entries, and all crowdfund specs. Clean revert against current main (no conflicts). Typecheck clean; full unit suite 3097/3097 green; crowdfund CLI integration specs 13/13 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of eb87fe7 (#248) — re-adds the Crowdfund standard to the SDK.
Why now
Crowdfund was removed because the chain's inclusive 0.1% protocol fee taxed the mint-escrow deposit leg, so a fully-funded crowdfund could never withdraw/refund (funds stuck). The chain is moving to an additive protocol-fee model in v33 (recipient/escrow receives the full quoted amount; fee charged on top), which unblocks crowdfund withdraw/refund. The original builders were written for the additive model, so restoring them is correct.
What's restored
core/crowdfunds.ts+core/builders/crowdfund.ts, the builder preset, CLIcrowdfundscommand surface, agent skill, verifier, standards-info, design-decision + review-ux registry entries, and all crowdfund specs.Verification
main(no conflicts).tsctypecheck clean.Cross-repo (merge order)
This is the first of three coordinated PRs. Merge + publish this SDK first, then bump
bitbadgesin the indexer and frontend PRs:🤖 Generated with Claude Code