889116 - Make log optional + zip log file when size exceed retention_size#5
Open
pngouahbeapi wants to merge 2 commits into
Open
889116 - Make log optional + zip log file when size exceed retention_size#5pngouahbeapi wants to merge 2 commits into
pngouahbeapi wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 635db99. Configure here.
Rahe
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Adds new behavior to log rotation (optional ZIP compression and file deletion) and changes construction via a new
$write_enabledflag, which could affect logging/rotation expectations and filesystem permissions.Overview
Adds a new
$write_enabledconstructor flag toBea_Logto makelog_this()a no-op when logging is disabled (no disk I/O).Enhances log rotation so that when a log exceeds
retention_sizeit is renamed and, ifZipArchiveis available, the rotated file is compressed into a sibling.zipand the uncompressed rotated log is removed.Updates docs and bumps plugin version to
0.4to reflect the new constructor signature, defaults, and rotation/compression behavior.Reviewed by Cursor Bugbot for commit 90a941d. Bugbot is set up for automated code reviews on this repo. Configure here.