Skip to content

refactor: 웹 동아리 분과 이모지 컬럼명 변경#654

Merged
JanooGwan merged 1 commit into
developfrom
refactor/rename-web-club-category-emoji
May 29, 2026
Merged

refactor: 웹 동아리 분과 이모지 컬럼명 변경#654
JanooGwan merged 1 commit into
developfrom
refactor/rename-web-club-category-emoji

Conversation

@JanooGwan
Copy link
Copy Markdown
Contributor

@JanooGwan JanooGwan commented May 29, 2026

🔍 개요

  • web_club.image_url 컬럼이 실제 이미지 URL이 아니라 분과별 이모지 값을 담게 되어, DB 컬럼명과 웹사이트 API 응답 필드명을 의미에 맞게 변경했습니다.

🚀 주요 변경 내용

  • WebClub 엔티티의 imageUrl 필드를 categoryEmoji로 변경하고, DB 컬럼을 category_emoji로 매핑했습니다.
  • V85__rename_web_club_image_url_to_category_emoji.sql 마이그레이션을 추가해 기존 web_club.image_url 컬럼을 category_emoji로 rename합니다.
  • 웹사이트 동아리 목록/상세 응답의 동아리 필드를 imageUrl에서 categoryEmoji로 변경했습니다.
  • 동아리 정보 수정 요청 이벤트와 Slack 알림에서 현재 동아리 이모지 값을 currentCategoryEmoji로 전달하도록 정리했습니다.
  • 관련 fixture 및 웹사이트/서비스/Slack listener 테스트의 기대 필드를 categoryEmoji 기준으로 수정했습니다.

💬 참고 사항

  • 대학 로고를 담는 web_university.image_url 및 일반 동아리 이미지 URL 필드는 실제 URL 의미를 유지하므로 변경하지 않았습니다.
  • emoji보다 category_emoji가 분과 기준 이모지라는 의미를 더 명확하게 드러내므로 해당 이름을 선택했습니다.
  • 실제 stage/prod DB 마이그레이션 실행은 자동 수행 금지 항목이라 PR에는 Flyway 파일만 포함했습니다.
  • Copilot reviewer는 GitHub App 제약으로 API 지정이 불가해 PR 페이지에서 직접 Request가 필요합니다.

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@JanooGwan, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 59 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 485fea33-d10c-450a-bebc-18cfdffa623a

📥 Commits

Reviewing files that changed from the base of the PR and between 1464f71 and a607230.

📒 Files selected for processing (11)
  • src/main/java/gg/agit/konect/domain/club/event/ClubInformationUpdateRequestedEvent.java
  • src/main/java/gg/agit/konect/domain/website/dto/WebsiteClubDetailResponse.java
  • src/main/java/gg/agit/konect/domain/website/dto/WebsiteClubsResponse.java
  • src/main/java/gg/agit/konect/domain/website/model/WebClub.java
  • src/main/java/gg/agit/konect/infrastructure/slack/listener/ClubRegistrationRequestSlackListener.java
  • src/main/java/gg/agit/konect/infrastructure/slack/service/SlackNotificationService.java
  • src/main/resources/db/migration/V85__rename_web_club_image_url_to_category_emoji.sql
  • src/test/java/gg/agit/konect/integration/domain/website/WebsiteApiTest.java
  • src/test/java/gg/agit/konect/support/fixture/WebClubFixture.java
  • src/test/java/gg/agit/konect/unit/domain/club/service/ClubRegistrationRequestServiceTest.java
  • src/test/java/gg/agit/konect/unit/infrastructure/slack/listener/ClubRegistrationRequestSlackListenerTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/rename-web-club-category-emoji

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JanooGwan JanooGwan added 리팩토링 리팩터링을 위한 이슈입니다. DB DB 마이그레이션을 위한 라벨입니다. labels May 29, 2026
@JanooGwan JanooGwan self-assigned this May 29, 2026
@JanooGwan JanooGwan requested a review from Copilot May 29, 2026 08:38
@github-actions
Copy link
Copy Markdown

🧪 JaCoCo Coverage Report (Changed Files)

Summary

  • Overall Coverage: 80.0% ✅
  • Covered Lines: 88 / 110
  • Changed Files: 6

Coverage by File

Class Coverage Lines Status
SlackNotificationService
gg.agit.konect.infrastructure.slack.service
58.5% 31/53 ⚠️
ClubInformationUpdateRequestedEvent
gg.agit.konect.domain.club.event
100.0% 20/20
ClubRegistrationRequestSlackListener
gg.agit.konect.infrastructure.slack.listener
100.0% 37/37

📊 View Workflow Run

@JanooGwan JanooGwan merged commit a2e98d9 into develop May 29, 2026
5 of 6 checks passed
@JanooGwan JanooGwan deleted the refactor/rename-web-club-category-emoji branch May 29, 2026 08:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB DB 마이그레이션을 위한 라벨입니다. 리팩토링 리팩터링을 위한 이슈입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants