Skip to content

Sync eng/common directory with azure-sdk-tools for PR 16621 #7282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azure-sdk-automation wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sync eng/common directory with azure-sdk-tools for PR 16621 #7282

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a7cdd8
Fix New-RegenerateMatrix dropping packages from the matrix
live1206 Jul 29, 2026
23acbfc
Validate JobCount and MinimumPerJob are positive
live1206 Jul 29, 2026
def4d89
Merge remote-tracking branch 'origin/main' into sync-eng-common-fix/r…
Copilot Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion eng/common/scripts/New-RegenerateMatrix.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,15 @@ param (
[Parameter()]
[string]$OutputVariableName,

# Both counts are used as divisors when splitting the items, so reject zero and
# negative values here rather than failing later with a divide-by-zero.
[Parameter()]
[ValidateRange(1, [int]::MaxValue)]
[int]$JobCount = 8,

# The minimum number of items per job. If the number of items is less than this, then the number of jobs will be reduced.
[Parameter()]
[ValidateRange(1, [int]::MaxValue)]
[int]$MinimumPerJob = 10,

[Parameter()]
Expand Down Expand Up @@ -40,7 +44,11 @@ function Split-Items([array]$Items) {
}

$itemsPerGroup = [math]::Floor($itemCount / $JobCount)
$largeJobCount = $itemCount % $itemsPerGroup
# The remainder has to be taken over the number of groups, not the size of a group.
# Taking it over $itemsPerGroup produces too few large groups whenever
# $itemCount % $itemsPerGroup -lt $itemCount % $JobCount, and the trailing items are
# then silently dropped from the matrix.
$largeJobCount = $itemCount % $JobCount
$groups = [object[]]::new($JobCount)

$i = 0
Expand Down
Loading