Retry large storage query live tests - #7280
Merged
JinmingHu (Jinming-Hu) merged 2 commits intoAug 7, 2026
Merged
Conversation
Retry response-body transport failures once in the Blob and Data Lake large query live tests, while preserving immediate failures for requests and assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the existing Storage test convention for informational retry messages instead of writing directly to standard output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
JinmingHu (Jinming-Hu)
marked this pull request as ready for review
August 4, 2026 23:35
JinmingHu (Jinming-Hu)
requested review from
Larry Osterman (LarryOsterman),
Amanda Nguyen (amnguye) and
Anton Kolesnyk (antkmsft)
as code owners
August 4, 2026 23:35
JinmingHu (Jinming-Hu)
requested a review
from Gauri Lamunion (gapra-msft)
as a code owner
August 4, 2026 23:35
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces flakiness in large-query LIVE tests for Azure Storage Blobs and Azure Storage Data Lake by retrying the query once when a transport failure occurs while streaming the response body, and by additionally validating that the entire expected output was read.
Changes:
- Wrap large query result streaming reads in a 2-attempt loop that retries only on
Azure::Core::Http::TransportExceptionduring response body reads. - Keep assertion failures and request-time failures immediate by limiting the
try/catchscope to the read/compare loop. - Add a final
ASSERT_EQ(comparePos, jsonData.size())to validate full expected output length was received.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/storage/azure-storage-files-datalake/test/ut/datalake_file_query_test.cpp | Adds a one-time retry on transport failures during large Data Lake query response streaming and validates full output length. |
| sdk/storage/azure-storage-blobs/test/ut/blob_query_test.cpp | Adds a one-time retry on transport failures during large blob query response streaming and validates full output length. |
Member
Author
|
/azp run cpp - storage |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Anton Kolesnyk (antkmsft)
approved these changes
Aug 6, 2026
JinmingHu (Jinming-Hu)
deleted the
stgxx_fix_storage_nightly_query_flake
branch
August 7, 2026 00:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
BlockBlobClientTest.QueryLargeBlob_LIVEONLY_(LIVE)DataLakeFileClientTest.QueryLargeBlob_LIVEONLY_(LIVE)azure-storage-blobs-testandazure-storage-files-datalake-testFixes the macOS nightly flake seen in Azure Pipelines build 6658328 where the streaming query response failed with CURLE 56.