Migrate CloudHsm module to tsp - #30010
Draft
JunKai-v wants to merge 1 commit into
Draft
Conversation
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the Az.CloudHsm module’s code generation workflow from AutoRest (Swagger) to TypeSpec by adding TypeSpec emitter configuration and updating generated metadata/artifacts for the CloudHsm module.
Changes:
- Added TypeSpec PowerShell emitter configuration (
tspconfig.yaml) and pinned spec location (tsp-location.yaml) for CloudHsm generation. - Updated module manifest metadata (generation date, Az.Accounts minimum version) and solution project GUID references.
- Refreshed generated module metadata files (assembly info, docs module GUID, generation id) and updated module changelog.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CloudHsm/CloudHsm/ChangeLog.md | Notes the generator migration in release notes. |
| src/CloudHsm/CloudHsm/Az.CloudHsm.psd1 | Updates manifest generation stamp and Az.Accounts dependency floor. |
| src/CloudHsm/CloudHsm.sln | Updates solution project GUID mapping for Az.CloudHsm project entry. |
| src/CloudHsm/CloudHsm.Autorest/tspconfig.yaml | Introduces TypeSpec PowerShell emitter options and directives for cmdlet shaping. |
| src/CloudHsm/CloudHsm.Autorest/tsp-location.yaml | Pins the TypeSpec/spec source location to a specific repo commit for reproducible generation. |
| src/CloudHsm/CloudHsm.Autorest/README.md | Removes embedded AutoRest YAML configuration section from the module README. |
| src/CloudHsm/CloudHsm.Autorest/Properties/AssemblyInfo.cs | Updates generated assembly metadata (including AssemblyTitle). |
| src/CloudHsm/CloudHsm.Autorest/generate-info.json | Updates generation id metadata. |
| src/CloudHsm/CloudHsm.Autorest/docs/Az.CloudHsm.md | Updates documentation module GUID header metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Migrated code generation from AutoRest (Swagger) to TypeSpec. No user-facing changes in this release. |
| # Generated by: Microsoft Corporation | ||
| # | ||
| # Generated on: 26/06/2025 | ||
| # Generated on: 14-Aug-26 |
| [assembly: System.Reflection.AssemblyCopyrightAttribute("Copyright © Microsoft")] | ||
| [assembly: System.Reflection.AssemblyProductAttribute("Microsoft Azure PowerShell")] | ||
| [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - CloudHsm")] | ||
| [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - HardwareSecurityModules")] |
Comment on lines
+90
to
+95
| - where: | ||
| verb: ^Backup$|^Restore$ | ||
| subject: '' | ||
| parameter-name: Name | ||
| set: | ||
| parameter-name: SkuName |
Comment on lines
22
to
24
| ## Development | ||
| For information on how to develop for `Az.CloudHsm`, see [how-to.md](how-to.md). | ||
| <!-- endregion --> |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.