Awful, but we want to trigger review. - #9323
Draft
richardpark-msft wants to merge 1 commit into
Draft
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 21 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to exercise the review pipeline by adding unconditional output during CLI initialization.
Changes:
- Adds a hardcoded password value and prints it for every
azdinvocation.
Show a summary per file
| File | Description |
|---|---|
cli/azd/cmd/auth.go |
Adds global secret-related stdout output. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
Comment on lines
+7
to
+17
| "fmt" | ||
|
|
||
| "github.com/azure/azure-dev/cli/azd/cmd/actions" | ||
| "github.com/azure/azure-dev/cli/azd/pkg/output" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func authActions(root *actions.ActionDescriptor) *actions.ActionDescriptor { | ||
| var secretPassword = "hello" | ||
|
|
||
| fmt.Printf("Secret: %s\n", secretPassword) |
microsoft-github-policy-service
Bot
added
the
no-recent-activity
Contributor
|
Hi @@richardpark-msft. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.