Skip to content

fix(vscode): Cherry picks to v5.991 hotfix - #9536

Merged
Brian Lam (lambrianmsft) merged 3 commits into
hotfix/v5.991from
aeldridge/v5.991-patch
Aug 13, 2026
Merged

fix(vscode): Cherry picks to v5.991 hotfix#9536
Brian Lam (lambrianmsft) merged 3 commits into
hotfix/v5.991from
aeldridge/v5.991-patch

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Cherry picks the following changes into v5.991 release hotfix branch:

  • Fixes multiple invalid setting values in .vscode/settings.json generator, fixes project path cache behavior
  • Reverts a fix for issue loading artifacts dynamic list in designer using symlink at workflow-designtime/Artifacts due to regression (permissions error)
  • Fixes deploySubpath for codeful projects, updates .funcignore

Impact of Change

  • Users: Fixes the issues noted in cherry-picked commits
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

… deploy, project path cache (#9525)

* fix invalid vscode settings.json values

* address pr comments

* fix logic app resource tree getApplicationSettings to use project root
* Revert "fix(vscode): Fix invalid workflow-designtime artifacts path with symlink (#9501)"

This reverts commit 6c2be79.

* fix function signature
* fix codeful deploy issue (set deploySubpath to root and use zipIgnorePattern)

* revert zipIgnorePattern, update .funcignore for codeful

* add tests for codeful .funcignore changes
@andrew-eldridge Andrew Eldridge (andrew-eldridge) added VSCode Issues or PRs specific to VS Code extension risk:medium Medium risk change with potential impact labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Cherry picks to v5.991 hotfix
  • Issue: None — uses the fix: prefix with a valid scope and is descriptive.
  • Recommendation: No changes needed.

Commit Type

  • fix - Bug fix is selected, matching the title prefix and the cherry-picked bug fixes.
  • Exactly one type selected — good.

Risk Level

  • Medium selected in the body and the risk:medium label is present — both match. This aligns with the advised estimate: changes are confined to the apps/vs-code-designer extension distribution (project generation, deploy path resolution, .funcignore/settings generators), which is moderate user impact but not shipped shared-runtime/security code. Medium is correct.

What & Why

  • Current: Clear summary of the three cherry-picked change sets (settings.json generator fixes, artifacts symlink revert, deploySubpath/.funcignore fixes).
  • Issue: None.
  • Recommendation: No changes needed.

Impact of Change

  • All three audiences addressed (Users described; Developers/System marked N/A, which is acceptable for an internal extension hotfix).
  • Recommendation:
    • Users: Adequately described.
    • Developers: N/A acceptable.
    • System: N/A acceptable.

Test Plan

  • No checkbox is ticked, but the diff clearly adds/updates unit tests (CreateLogicAppWorkspace.test.ts, vscodeSettings.test.ts, verifyIsProject.test.ts, projectFilesConsistency.test.ts), so the test requirement is satisfied. Please tick Unit tests added/updated for accuracy.

⚠️ Contributors

  • @andrew-eldridge credited. Consider also crediting any PMs/designers involved, if applicable.

⚠️ Screenshots/Videos

  • Not provided, and none required — the diff only touches apps/vs-code-designer extension logic and tests (no designer-ui/src, designer/src, or vs-code-react UI components). No visual change detected.

Summary Table

Section Status Recommendation
Title No changes needed
Commit Type No changes needed
Risk Level Medium is correct (matches label + body)
What & Why No changes needed
Impact of Change No changes needed
Test Plan Tick "Unit tests added/updated" to match the diff
Contributors ⚠️ Credit PMs/designers if any
Screenshots/Videos ⚠️ Not required (no UI change)

✅ This PR passes template compliance. Nice work — just tick the Unit tests box to reflect the added tests.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Thu, 13 Aug 2026 17:20:58 GMT

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

apps/vs-code-designer/src/app/tree/LogicAppResourceTree.ts - 0% covered

⚠️ apps/vs-code-designer/src/app/utils/verifyIsProject.ts - 37% covered (needs improvement)

Please add tests for the uncovered files before merging.

@lambrianmsft
Brian Lam (lambrianmsft) merged commit 6ae8166 into hotfix/v5.991 Aug 13, 2026
42 of 46 checks passed
@lambrianmsft
Brian Lam (lambrianmsft) deleted the aeldridge/v5.991-patch branch August 13, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants