refactor(vscode): Workspace util cleanup

[Andrew Eldridge (andrew-eldridge)]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

Impact of Change

• Users:
• Developers:
• System:

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in:

Contributors

Screenshots/Videos

[github-actions]

📊 Coverage Check

No source files changed in this PR.

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: refactor(vscode): Workspace util cleanup
• Issue: None — valid refactor: prefix with scope and a descriptive summary.
• Recommendation: No change needed.

---

❌ Commit Type

• No commit type box is checked in the body (all boxes are empty - [ ]).
• Note: Check the refactor box — this change restructures/renames workspace utilities without altering user-facing behavior.

---

❌ Risk Level

• No Risk Level box is selected AND no risk:* label is applied (only needs-pr-update is present). Based on the diff — a refactor of workspace utilities in apps/vs-code-designer (extension distribution code) — the correct level is Medium. Please check the Medium box and add the risk:medium label so the body, label, and advised estimate all match.

---

❌ What & Why

• Current: Empty (only the placeholder comment remains).
• Issue: This required section is blank.
• Recommendation: Describe what changed and why, e.g. "Renamed and consolidated workspace path helpers (getWorkspaceRoot/getWorkspaceFile → getWorkspaceFilePath/getWorkspaceFilePathInParent), added hasLogicAppInWorkspace, and centralized path-equality via isPathEqual. Reduces duplication and clarifies workspace-file resolution."

---

⚠️ Impact of Change

• The Impact section is left as placeholders. Not blocking, but please fill it in.
• Recommendation:
  • Users: No user-facing behavior change expected (internal refactor of VS Code extension workspace resolution).
  • Developers: Public util function names changed (getWorkspaceRoot→getWorkspaceFilePath, getWorkspacePath→getContainingWorkspaceFolder, tryGetWorkspaceFolderLogicApps→getWorkspaceFolderLogicApps, etc.). Update call sites accordingly.
  • System: VS Code extension only; no new runtime dependencies.

---

✅ Test Plan

• Although no Test Plan boxes are checked, the diff updates multiple unit tests (workspace.test.ts, ensureWorkspace.test.ts, publishCodefulProject.test.ts, createUnitTest.test.ts, etc.) to cover the renamed utilities. This satisfies the test requirement. Please still check Unit tests added/updated.

---

⚠️ Contributors

• Contributors section is blank. If PMs, designers, or reviewers contributed, credit them. Never blocking.

---

⚠️ Screenshots/Videos

• No UI files under libs/designer-ui/src, libs/designer/src, or apps/vs-code-react/src UI components are touched — this is non-visual extension logic. No screenshots required.

---

Summary Table

Section	Status	Recommendation
Title	✅	No change needed
Commit Type	❌	Check the refactor box
Risk Level	❌	Select Medium and add risk:medium label
What & Why	❌	Fill in what changed and why
Impact of Change	⚠️	Fill in Users/Developers/System
Test Plan	✅	Check Unit tests added/updated
Contributors	⚠️	Credit contributors if any
Screenshots/Videos	⚠️	Not required (non-visual)

---

This PR is blocked until you select a Commit Type (refactor), declare the Risk Level as Medium in both the body and a risk:medium label, and fill in the required What & Why section. Tests are covered.

---

Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Thu, 13 Aug 2026 21:25:52 GMT