fix(vscode): Revert local artifacts workflow-designtime path fix - #9529
Merged
Brian Lam (lambrianmsft) merged 2 commits intoAug 12, 2026
Merged
Conversation
Andrew Eldridge (andrew-eldridge)
requested review from
Bryan Bennett (bjbennet) and
Brian Lam (lambrianmsft)
and
a balanced review from Copilot
August 12, 2026 16:49
Andrew Eldridge (andrew-eldridge)
added
VSCode
Copilot started reviewing on behalf of
Andrew Eldridge (andrew-eldridge)
August 12, 2026 16:50
View session
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:Revert PR detected — This PR reverts a previously merged fix (title starts with
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No action needed |
| Commit Type | ✅ | Auto-passed (revert) |
| Risk Level | ✅ | Matches medium estimate |
| What & Why | ✅ | No action needed |
| Impact of Change | ✅ | No action needed |
| Test Plan | ✅ | Auto-passed (revert) |
| Contributors | ✅ | Credited |
| Screenshots/Videos | ✅ | Not applicable |
✅ This is a revert PR and is automatically approved. Good to merge!
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 12 Aug 2026 16:56:20 GMT
Contributor
📊 Coverage Check🎉 All changed files have adequate test coverage! |
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the VS Code design-time Artifacts junction workaround to prevent deployment permission failures.
Changes:
- Removes Artifacts junction creation.
- Removes associated mocks and unit tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
projectFilesConsistency.ts |
Removes junction creation logic. |
projectFilesConsistency.test.ts |
Removes junction-specific tests and mocks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Brian Lam (lambrianmsft)
approved these changes
Aug 12, 2026
Brian Lam (lambrianmsft)
deleted the
aeldridge/vscode-revert-local-artifacts-fix
branch
August 12, 2026 17:58
Brian Lam (lambrianmsft)
pushed a commit
that referenced
this pull request
Aug 13, 2026
* fix(vscode): Fix invalid vscode settings.json values, codeful project deploy, project path cache (#9525) * fix invalid vscode settings.json values * address pr comments * fix logic app resource tree getApplicationSettings to use project root * fix(vscode): Revert local artifacts workflow-designtime path fix (#9529) * Revert "fix(vscode): Fix invalid workflow-designtime artifacts path with symlink (#9501)" This reverts commit 6c2be79. * fix function signature * fix(vscode): Codeful project deploy fix (#9527) * fix codeful deploy issue (set deploySubpath to root and use zipIgnorePattern) * revert zipIgnorePattern, update .funcignore for codeful * add tests for codeful .funcignore changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
The design-time process incorrectly ignores the set ProjectDirectoryPath setting and searches
<project root>/workflow-designtime/Artifactsin dynamic list apis. This was previously addressed by creating a symlink at this location to<project root>/Artifactsbut this has caused a regression in deploy command due to permissions issues. Reverting the original fix, will take a separate backend fix instead.Impact of Change
Test Plan
Contributors
Andrew Eldridge (@andrew-eldridge)