fix(vscode): Codeful project deploy fix - #9527
Merged
Andrew Eldridge (andrew-eldridge) merged 4 commits intoAug 13, 2026
Merged
Conversation
Andrew Eldridge (andrew-eldridge)
requested review from
Bryan Bennett (bjbennet) and
Brian Lam (lambrianmsft)
and
a balanced review from Copilot
August 12, 2026 04:31
Copilot started reviewing on behalf of
Andrew Eldridge (andrew-eldridge)
August 12, 2026 04:32
View session
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
✅ Screenshots/Videos
Summary Table
✅ All checks pass — this PR is compliant and cleared to merge.Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 12 Aug 2026 21:28:25 GMT |
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
❌ Commit Type
❌ Risk Level
✅ What & Why
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ❌ | Check fix - Bug fix |
| Risk Level | ❌ | Select Medium in body to match risk:medium label + advised estimate |
| What & Why | ✅ | No change needed |
| Impact of Change | Fill in Users/Developers/System | |
| Test Plan | ✅ | Tick Unit tests added/updated |
| Contributors | ✅ | No change needed |
| Screenshots/Videos | Not required (non-visual) |
This PR is blocked: no Commit Type is selected and no Risk Level box is checked in the body. Check fix - Bug fix and Medium (advised risk = Medium, matching the risk:medium label), then re-request review.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 12 Aug 2026 04:32:39 GMT
Contributor
📊 Coverage Check🎉 All changed files have adequate test coverage! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes codeful deployment by deploying from the project root and excluding unnecessary build artifacts.
Changes:
- Uses the project root as the codeful deployment path.
- Adds codeful-specific
.funcignoreentries. - Updates related unit tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
vscodeSettings.ts |
Sets codeful deployment path to .. |
vscodeSettings.test.ts |
Updates generated-settings expectations. |
CreateLogicAppWorkspace.ts |
Adds codeful .funcignore exclusions. |
CreateLogicAppWorkspace.test.ts |
Updates common .funcignore expectations. |
CreateLogicAppVSCodeContents.test.ts |
Updates generated VS Code settings expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Andrew Eldridge (andrew-eldridge)
enabled auto-merge (squash)
August 12, 2026 20:52
Bryan Bennett (bjbennet)
approved these changes
Aug 13, 2026
Andrew Eldridge (andrew-eldridge)
deleted the
aeldridge/vscode-codeful-deploy-fix
branch
August 13, 2026 16:56
Brian Lam (lambrianmsft)
pushed a commit
that referenced
this pull request
Aug 13, 2026
* fix(vscode): Fix invalid vscode settings.json values, codeful project deploy, project path cache (#9525) * fix invalid vscode settings.json values * address pr comments * fix logic app resource tree getApplicationSettings to use project root * fix(vscode): Revert local artifacts workflow-designtime path fix (#9529) * Revert "fix(vscode): Fix invalid workflow-designtime artifacts path with symlink (#9501)" This reverts commit 6c2be79. * fix function signature * fix(vscode): Codeful project deploy fix (#9527) * fix codeful deploy issue (set deploySubpath to root and use zipIgnorePattern) * revert zipIgnorePattern, update .funcignore for codeful * add tests for codeful .funcignore changes
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
bin/Release/.../publishfolder doesn't containlib/codefulwhich the runtime searches for codeful worker. So effectiveDeployPath must be project root rather than the publish path.Impact of Change
Test Plan
Contributors
Andrew Eldridge (@andrew-eldridge)