Skip to content

fix(vscode): Codeful project deploy fix - #9527

Merged
Andrew Eldridge (andrew-eldridge) merged 4 commits into
mainfrom
aeldridge/vscode-codeful-deploy-fix
Aug 13, 2026
Merged

fix(vscode): Codeful project deploy fix#9527
Andrew Eldridge (andrew-eldridge) merged 4 commits into
mainfrom
aeldridge/vscode-codeful-deploy-fix

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Impact of Change

  • Users: Fixes regression where deployed codeful projects would not work due to codeful worker not found
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

@andrew-eldridge Andrew Eldridge (andrew-eldridge) added VSCode Issues or PRs specific to VS Code extension risk:medium Medium risk change with potential impact labels Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Codeful project deploy fix
  • Issue: None — valid fix: prefix with a (vscode) scope, and descriptive of the regression being fixed.
  • Recommendation: No change needed.

Commit Type

  • Exactly one box selected: fix - Bug fix.
  • This correctly matches the deployment regression fix in the diff.

Risk Level

  • Declared Medium in the body, and the risk:medium label matches. My advised estimate is also Medium — the changes affect the apps/vs-code-designer extension distribution (deploy path, .funcignore, and generated VS Code settings), which is shipped runtime tooling but not core shared/security surface. Declared level matches advised estimate. ✅

What & Why


Impact of Change

  • All three audiences addressed (Users noted; Developers/System marked N/A).
  • Recommendation:
    • Users: Fixes broken codeful deployments (worker not found) — well stated.
    • Developers: N/A is acceptable here.
    • System: N/A is acceptable here.

Test Plan

  • Unit tests added/updated is checked and confirmed in the diff (new .funcignore codeful-artifact tests, updated deploySubpath / zipIgnorePattern assertions). Manual testing also checked. Passes CHECK TESTS.

Contributors

  • @andrew-eldridge credited.

Screenshots/Videos

  • Not required — the diff touches apps/vs-code-designer build/deploy logic and tests, not visual UI components in libs/designer-ui/src, libs/designer/src, or apps/vs-code-react UI. No visual change.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Medium is correct
What & Why No change needed
Impact of Change No change needed
Test Plan Unit tests confirmed in diff
Contributors Credited
Screenshots/Videos Not applicable

✅ All checks pass — this PR is compliant and cleared to merge.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 12 Aug 2026 21:28:25 GMT

@github-actions

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Codeful project deploy fix
  • Issue: None — valid fix(scope): prefix and descriptive.
  • Recommendation: No change needed.

Commit Type

  • No commit type box is checked in the body.
  • Note: Check - [x] fix - Bug fix to match your title prefix. (Also note your template still reads feature instead of feat; the reviewed change is a bug fix.)

Risk Level

  • No Risk Level box is selected in the body (zero selected → fail), even though the risk:medium label is applied. My advised estimate is Medium (changes to apps/vs-code-designer extension distribution / deployment behavior). Select - [x] Medium so the body matches the risk:medium label and the advised estimate.

What & Why


⚠️ Impact of Change


Test Plan

  • No checkboxes are ticked, but the diff updates unit tests (CreateLogicAppVSCodeContents.test.ts, CreateLogicAppWorkspace.test.ts, vscodeSettings.test.ts), so the test requirement is satisfied. Please still tick - [x] Unit tests added/updated.

Contributors


⚠️ Screenshots/Videos

  • Not required — the change is in the VS Code extension host (deploy/config logic), not a visual UI change.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type Check fix - Bug fix
Risk Level Select Medium in body to match risk:medium label + advised estimate
What & Why No change needed
Impact of Change ⚠️ Fill in Users/Developers/System
Test Plan Tick Unit tests added/updated
Contributors No change needed
Screenshots/Videos ⚠️ Not required (non-visual)

This PR is blocked: no Commit Type is selected and no Risk Level box is checked in the body. Check fix - Bug fix and Medium (advised risk = Medium, matching the risk:medium label), then re-request review.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 12 Aug 2026 04:32:39 GMT

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Check

🎉 All changed files have adequate test coverage!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes codeful deployment by deploying from the project root and excluding unnecessary build artifacts.

Changes:

  • Uses the project root as the codeful deployment path.
  • Adds codeful-specific .funcignore entries.
  • Updates related unit tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vscodeSettings.ts Sets codeful deployment path to ..
vscodeSettings.test.ts Updates generated-settings expectations.
CreateLogicAppWorkspace.ts Adds codeful .funcignore exclusions.
CreateLogicAppWorkspace.test.ts Updates common .funcignore expectations.
CreateLogicAppVSCodeContents.test.ts Updates generated VS Code settings expectations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@andrew-eldridge
Andrew Eldridge (andrew-eldridge) merged commit 0dacfee into main Aug 13, 2026
43 checks passed
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) deleted the aeldridge/vscode-codeful-deploy-fix branch August 13, 2026 16:56
Brian Lam (lambrianmsft) pushed a commit that referenced this pull request Aug 13, 2026
* fix(vscode): Fix invalid vscode settings.json values, codeful project deploy, project path cache (#9525)

* fix invalid vscode settings.json values

* address pr comments

* fix logic app resource tree getApplicationSettings to use project root

* fix(vscode): Revert local artifacts workflow-designtime path fix (#9529)

* Revert "fix(vscode): Fix invalid workflow-designtime artifacts path with symlink (#9501)"

This reverts commit 6c2be79.

* fix function signature

* fix(vscode): Codeful project deploy fix (#9527)

* fix codeful deploy issue (set deploySubpath to root and use zipIgnorePattern)

* revert zipIgnorePattern, update .funcignore for codeful

* add tests for codeful .funcignore changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants