Skip to content

chore(vscode): VS Code extension synthetics (initial pass) - #9519

Open
Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
mainfrom
aeldridge/vscode-synthetics
Open

chore(vscode): VS Code extension synthetics (initial pass)#9519
Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
mainfrom
aeldridge/vscode-synthetics

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Impact of Change

  • Users: N/A
  • Developers: N/A
  • System: Adds synthetics workflow for VS Code extension

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge), Brian Lam (@lambrianmsft)

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

  • Current: chore(vscode): VS Code extension synthetics (initial pass)
  • Issue: None — valid chore prefix with scope and a descriptive summary.
  • Recommendation: No change needed.

✅ Commit Type

  • chore - Maintenance/tooling is selected (exactly one).
  • Correct choice: this adds a scheduled synthetics CI workflow and updates the E2E test harness — no shipped product behavior changes.

✅ Risk Level

  • Exactly one box selected (Low) and the risk:low label matches. This aligns with my advised estimate: low. The change is plain CI/repository automation (a scheduled/workflow_dispatch synthetics workflow with no pull_request_target, no issues/pull-requests: write, no governance change) plus test-harness edits that don't ship to users.

❌ What & Why

  • Current: Empty — only the template comment remains.
  • Issue: This required section is blank. It must explain what changed and why.
  • Recommendation: Add something like: "Adds a vscode-e2e-synthetics.yml workflow that runs the ExTester harness on a weekday schedule against the marketplace-published extension (or a source build via workflow_dispatch), and extends run-e2e.ts to support a LA_E2E_VSIX_SOURCE=marketplace mode that installs the published VSIX via the VS Code CLI. Purpose: catch regressions in the shipped extension that source-only CI misses."

✅ Impact of Change

  • Section is filled in (System notes the synthetics workflow addition).
  • Recommendation:
    • Users: N/A (no user-facing change) — acceptable as stated.
    • Developers: Consider noting the new LA_E2E_VSIX_SOURCE env var and marketplace-install path in the harness.
    • System: Adds a scheduled CI synthetics workflow validating the published VS Code extension.

✅ Test Plan

  • This PR adds CI automation and test-harness plumbing — no shippable product code — so unit/E2E coverage is not required. "Manual testing completed" is a reasonable selection here.

✅ Contributors

✅ Screenshots/Videos

  • No visual UI files touched (.github/workflows/ and apps/vs-code-designer/src/test/), so screenshots are not required.

Summary Table

Section Status Recommendation
Title ✅ No change needed
Commit Type ✅ No change needed
Risk Level ✅ Matches advised low
What & Why ❌ Fill in what changed and why (currently empty)
Impact of Change ✅ Optional: mention new env var
Test Plan ✅ CI/harness change — no tests required
Contributors ✅ No change needed
Screenshots/Videos ✅ Not applicable

Almost there — the only blocker is the empty "What & Why" section. Add a brief description of what changed and why, and this PR will pass.

Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 12 Aug 2026 19:11:26 GMT

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

No source files changed in this PR.

@github-actions github-actions Bot mentioned this pull request Aug 12, 2026
Closed
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) marked this pull request as ready for review August 12, 2026 17:36
Copilot AI balanced review requested due to automatic review settings August 12, 2026 17:36
@andrew-eldridge Andrew Eldridge (andrew-eldridge) added risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension labels Aug 12, 2026
Copilot AI reviewed Aug 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds scheduled VS Code synthetic tests for the published marketplace extension using the existing ExTester harness.

Changes:

  • Adds marketplace/source extension selection and installation.
  • Adds scheduled activation and designer smoke tests.
  • Uploads failure screenshots and run metadata.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
apps/vs-code-designer/src/test/ui/run-e2e.ts Supports marketplace extension installation.
.github/workflows/vscode-e2e-synthetics.yml Defines scheduled and manual synthetic runs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/vscode-e2e-synthetics.yml
Comment on lines +151 to +152
echo "- **VSIX Source**: ${{ inputs.vsix_source || 'marketplace' }}" >> $GITHUB_STEP_SUMMARY
echo "- **Run Time**: $(date -u +'%Y-%m-%d %H:%M UTC')" >> $GITHUB_STEP_SUMMARY
Comment thread apps/vs-code-designer/src/test/ui/run-e2e.ts
Comment on lines +672 to +677
// Read extension metadata from package.json.
// In marketplace mode, dist/ may not exist — fall back to the project-level package.json.
const distPkgPath = path.join(distDir, 'package.json');
const projectPkgPath = path.join(projectDir, 'package.json');
const pkgJsonPath = fs.existsSync(distPkgPath) ? distPkgPath : projectPkgPath;
const pkgJson = JSON.parse(fs.readFileSync(pkgJsonPath, 'utf8'));
@andrew-eldridge Andrew Eldridge (andrew-eldridge) added risk:low Low risk change with minimal impact and removed risk:low Low risk change with minimal impact needs-pr-update labels Aug 12, 2026
This was referenced Aug 13, 2026
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@lambrianmsft Brian Lam (lambrianmsft) lambrianmsft approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-pr-update risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrew-eldridge @lambrianmsft