fix(bb): suppress asserts while deriving Chonk VKs#24079
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly debug build failed in run https://github.com/AztecProtocol/aztec-packages/actions/runs/27529171550 while running
bbapi_tests ChonkPinnedIvcInputsTest.AllPinnedFlowson the pinned Chonk flowdeploy_ecdsar1+sponsored_fpc.Root cause:
ChonkComputeVkderives the hiding-kernel VK from bytecode with an empty witness. In debug builds, that bytecode can execute recursive-kernel public-input consistency checks whose nativeBB_ASSERT_DEBUGcomparisons require real witness-backed proof data. VK derivation is witness-independent, so those assertions should not fail a VK-only path.Fix: wrap the shared Chonk VK derivation helper with
BB_DISABLE_ASSERTS(), matching existing debug-only VK/check flows that intentionally construct circuits without satisfying witnesses.Testing
cmake --build build-debug --target bbapi_testsAZTEC_REPO_ROOT=/home/aztec-dev/aztec-packages CHONK_PINNED_IVC_FLOW=deploy_ecdsar1+sponsored_fpc CHONK_PINNED_IVC_FLOW_LIMIT=1 ./build-debug/bin/bbapi_tests --gtest_filter=ChonkPinnedIvcInputsTest.AllPinnedFlowscmake --build build --target bbapi_testsAZTEC_REPO_ROOT=/home/aztec-dev/aztec-packages CHONK_PINNED_IVC_FLOW=deploy_ecdsar1+sponsored_fpc CHONK_PINNED_IVC_FLOW_LIMIT=1 ./build/bin/bbapi_tests --gtest_filter=ChonkPinnedIvcInputsTest.AllPinnedFlowsCreated by claudebox · group:
slackbot