fix: return Chonk prove verification key#24078
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChonkProvebb prove --write_vkRoot cause
The nightly debug failure was in
ChonkPinnedIvcInputsTest.AllPinnedFlows, not in CMake compilation.ChonkProvegenerated a proof and verified it successfully with the accumulated hiding-kernel VK. The test then recomputed a VK throughChonkComputeVkfrom only the hiding-kernel bytecode. That write-VK/mock construction produced different hiding-kernel metadata (pub_inputs_offset673 instead of 669, different selector commitments), so the verifier parsed the proof public inputs against the wrong VK and hit the debug databus assertion.Verification
cmake --preset debug -DAVM=OFF -DAVM_TRANSPILER_LIB=cmake --build --preset debug --target bbapi_tests -j 16cmake --build --preset debug --target bb -j 16build-debug/bin/bbapi_tests --gtest_filter='BBApiMsgpack/*.DefaultConstructorRoundtrip'build-debug/bin/bbapi_tests --gtest_filter='BBApiInputValidation.*:CBind.*'NATIVE_PRESET=debug CHONK_PINNED_IVC_FLOW='deploy_ecdsar1+sponsored_fpc' scripts/run_test.sh bbapi_tests ChonkPinnedIvcInputsTest.AllPinnedFlowscorepack yarn prettier --check src/barretenberg/backend.tsNotes:
clang-formatis not installed in this container. Full TS typecheck was blocked by missing ignoredaztec-wsdbgenerated bindings, and ESLint was blocked by an unavailableeslint-plugin-importreferenced by the repo config.Created by claudebox · group:
slackbot