test(e2e): wait for L1 txs to be mined in token bridge tutorial test#24065
Open
spalladino wants to merge 1 commit into
Open
test(e2e): wait for L1 txs to be mined in token bridge tutorial test#24065spalladino wants to merge 1 commit into
spalladino wants to merge 1 commit into
Conversation
Fixes a race in `e2e_token_bridge_tutorial_test` where L1 setup transactions were submitted but not awaited before dependent bridge calls. - Waits for the `TestERC20.addMinter` transaction receipt before minting through the handler. - Waits for the `TokenPortal.initialize` transaction receipt before simulating `depositToAztecPublic`. - Prevents intermittent `SafeERC20FailedOperation(address token) (0x0)` when the portal deposit simulation runs before `underlying` is initialized. See http://ci.aztec-labs.com/e100f59864b9c18c for sample failed run.
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race in
e2e_token_bridge_tutorial_testwhere L1 setup transactions were submitted but not awaited before dependent bridge calls.TestERC20.addMintertransaction receipt before minting through the handler.TokenPortal.initializetransaction receipt before simulatingdepositToAztecPublic.SafeERC20FailedOperation(address token) (0x0)when the portal deposit simulation runs beforeunderlyingis initialized.See http://ci.aztec-labs.com/e100f59864b9c18c for sample failed run.