chore(bb): pin Chonk IVC inputs to e2dbfa3f to fix nightly debug build#24048
Closed
AztecBot wants to merge 1 commit into
Closed
chore(bb): pin Chonk IVC inputs to e2dbfa3f to fix nightly debug build#24048AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
barretenberg/cpp/scripts/chonk-inputs.hashfrom209dde8e69a27c9f(pinned 2026-05-21) toe2dbfa3f4092e24f, so the Nightly Debug Build goes green again.This is a plain pin bump — deliberately without the
ci-refresh-chonklabel or a--ci-skipmarker — so it runs normal merge-queue CI and can merge through the queue like any other PR. See "Why a plain bump" below.Root cause
Nightly Debug Build run 27399112032 (
next@fa063393) failed in:On circuit 10/10 (
hiding_kernel) of thedeploy_ecdsar1+sponsored_fpcpinned flow:The
hiding_kernelcircuit's public-input layout changed (offset 669 → 673, plus selector-commitment changes), so the precomputed VKs / proof baked into the pinnedivc-inputs.msgpackare stale. The reconstructedkernel_return_datareads the sentinel BN254 generator{1, 2}(an empty databus column) instead of the real return-data commitment, tripping the consistency check.That check is
BB_ASSERT_DEBUG(kernel_return_data_match, ...)atbarretenberg/cpp/src/barretenberg/chonk/chonk.cpp:169— a debug-only assertion compiled out of release/PR CI. Only the nightly debug build exercises it, which is why a stale pin slips past merge-queue CI and only the nightly catches it.The circuit change came from #23484 (
fix: harden batch chonk verifier, Jun 5) — it adds an independent batched-SRS MSM check binding the prover-supplied IPAG_0inIPA::batch_reduce_verify; the IPA verifier lives inside the hiding kernel, accounting for the +4 public inputs and changed selectors. It landed withoutci-refresh-chonk.Why
e2dbfa3fThe existing refresh PR #23924 already regenerated the pin to
e2dbfa3f4092e24fon 2026-06-08 (its CI uploaded the matchingbb-chonk-inputs-e2dbfa3f4092e24f.tar.gzto S3). That regen happened after #23484, so it reflects the 673-public-input hiding kernel. The only barretenberg change to land since is #23902 (pippenger/MSM prover rewrite) — MSM results are mathematically identical, so circuit shapes/VKs are unchanged. This PR's hash blob is byte-identical to #23924's.Normal CI here re-validates the pin end-to-end (
chonk_inputs.sh checkrecomputes the circuit VKs against the pinned tarball, andChonkPinnedIvcInputsTest.AllPinnedFlowsproves every flow). Ife2dbfa3fwere stale, CI fails and this won't merge.Why a plain bump (not
ci-refresh-chonk)The
ci-refresh-chonkflow ends by committing the new hash with a--ci-skiphead-commit marker. On those PRs the required merge-queue checks therefore never run, so auto-merge can never be satisfied and the PR rots. That is why #23924 (auto-merge enabled since Jun 7) and several othercb/refresh-chonk-*branches have sat open and unmerged whilenextstayed on the May-21 pin. Landing the already-validated hash as an ordinary PR sidesteps that trap.Supersedes/unblocks #23924.
Follow-up (separate, not in this PR)
Two systemic gaps worth a tracked fix so this stops recurring:
chonk_inputs.sh check(or a debug-asserts pinned-flow) at PR time, or having circuit-affecting PRs requireci-refresh-chonk.ci-refresh-chonkrefresh PRs are unmergeable by construction (--ci-skiphead commit vs. required checks); the refresh automation should produce a landable PR.Created by claudebox · group:
slackbot