chore: Improved handshake registry privacy docs#24018
Open
vezenovm wants to merge 4 commits into
Open
Conversation
nchamo
reviewed
Jun 12, 2026
| /// | ||
| /// # Privacy | ||
| /// The siloing described above means reading handshakes never compromises message secrecy: a reader only ever | ||
| /// derives secrets siloed to its own address. Handshake metadata is weaker, though. Incoming handshakes are announced |
Contributor
There was a problem hiding this comment.
The whole
Incoming handshakes are announced
/// via a bootstrap log under a tag derived from the recipient address (see
/// [`HandshakeRegistry::non_interactive_handshake`]), so their existence, count, and timing are observable by anyone
/// who knows that address, and [`HandshakeRegistry::get_handshakes`] exposes their decrypted payload to in-scope
/// callers.
is only applicable to non-interactive, it's weird that we specify that here
Contributor
Author
There was a problem hiding this comment.
I switched to having this on non_interactive_handshake and linking to it in the module comment
Co-authored-by: Nicolas Chamo <nicolas@chamo.com.ar>
…cs' into mv/handshake-registry-privacy-docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue just something I noticed while thinking about #23938 (comment)
Docs contain relevant privacy linkability when using the handshake registry contract.