Skip to content

update input_too_large threshold#544

Closed
GdoongMathew wants to merge 3 commits into
AsyncFuncAI:mainfrom
GdoongMathew:fix/max_token_msg
Closed

update input_too_large threshold#544
GdoongMathew wants to merge 3 commits into
AsyncFuncAI:mainfrom
GdoongMathew:fix/max_token_msg

Conversation

@GdoongMathew

Copy link
Copy Markdown
Contributor

Summary

Use the predefined MAX_INPUT_TOKENS in rag.py to determine input_too_large value.

* refactor chat streaming

* update `_is_token_limit_error` logic

* test: add chat provider unittests

* move `_is_token_limit_error` to module level

* remove unnecessary TYPE_CHECKING

* add EOF

* update prompt function

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates api/simple_chat.py to import and use the centralized MAX_INPUT_TOKENS constant from api.rag instead of using hardcoded token limit values (8000 and 7500) when validating the request size. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@GdoongMathew
GdoongMathew deleted the fix/max_token_msg branch July 18, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant