Skip to content

Fixes for 26.1 scene rendering: face culling, block render types, BE model data, texture blur - #118

Open
andrewsf wants to merge 4 commits into
AppliedEnergistics:mainfrom
andrewsf:fix/26.1-scene-rendering
Open

andrewsf wants to merge 4 commits into
AppliedEnergistics:mainfrom
andrewsf:fix/26.1-scene-rendering

Conversation

@andrewsf

Copy link
Copy Markdown

Fixes for rendering of 3D scenes and block images, found while fixing the web guide for AE2 @ 26.1.2

(More reasoning & explanation is in each commit message)

  1. Don't render hidden block faces in scenes:: Set cull=true. Resolves issues with white sparkles between blocks in 3D scenes.
  2. Render scene blocks using block render types: rendering of various blocks was too dark because the entity block sheets add directional lighting on top of the block models' existing baked-in shading. Restores the behavior that was lost between 1.21.4 and 1.21.8
  3. Get model data directly from block entities: Have GuidebookLevel ask block entities for their model data instead of using ModelDataManager, which is missing data for some BEs when they're placed from a structure. One symptom: ME Drives will have floating cell LEDs but missing cells
  4. Base exported texture blur on the magnification filter: use the mag filter for blur since it's used for magnification in the web viewer

Change order to fix 26.1 AE2 guide display

  1. In parallel:
    • guide: Fix 3D scenes with a pipeline table update: Fix broken 3D scenes for 26.1: update pipeline table guide#3
    • GuideME: (this PR)
      • Don't render hidden block faces in scenes
      • Render scene blocks with block render types, like 1.21
      • Get model data directly from block entities (fixes ME Drive cells)
      • Base exported texture blur on the magnification filter (fixes web viewer blurring when zoomed in)
  2. AE2: Update to the latest GuideME and publish the web content
  3. guide: Update for the published guide data:
    • Use diffuse lighting for entity_cutout_cull
    • Remove entity_translucent_cull

ModelBlockRenderer was created with cull=false, which made exports larger,
renders more expensive, and showed flickering specks in between blocks
The entity block sheets add directional lighting on top of the shading
already baked into block models, which made block sides too dark in
scenes and block images. Use the moving-block render types instead, like
GuideME was doing up to 1.21.4.
GuidebookLevel asked NeoForge's ModelDataManager, which is empty for
blocks placed from structures. Blocks that need model data
(e.g., ME Drive's cells) rendered without it, causing those
models to be missing in the scene
The block atlas uses linear filtering only when shrinking textures. The
exporter looked at that filter, so the web viewer was blurring all block
textures when zoomed in.
@andrewsf
andrewsf force-pushed the fix/26.1-scene-rendering branch from 26939cb to baa3839 Compare September 20, 2026 22:14
@andrewsf

andrewsf commented Sep 21, 2026 •

Copy link
Copy Markdown
Author

Don't render hidden block faces in scenes

Here's a screenshot of that symptom:

image
  1. Render scene blocks using block render types

Here's a comparison from the live guide:

image

Get model data directly from block entities

Comparison:

image

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant