store_attr no longer records __stored_args__; add init_args - #929
Merged
Conversation
jph00
deleted the
pr/store-attr-no-longer-records-stored-args-add-init
branch
September 3, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_attronly sets the attributes now. Thestore_argsparameter and the__stored_args__record it kept are gone.init_args(o)replaces the record for its readers: it returns the__init__parameters ofothat it holds as attributes, with their current values, which is what astore_attrclass holds. Display and logging code that read the record readsinit_argsinstead. See "store_attr" in the basics notebook.