fix(helm): wire watchNamespaces value into operator ConfigMap#2007
Open
jtomaszon wants to merge 1 commit into
Open
fix(helm): wire watchNamespaces value into operator ConfigMap#2007jtomaszon wants to merge 1 commit into
jtomaszon wants to merge 1 commit into
Conversation
The configs.files.config.yaml.watch.namespaces.include field was hardcoded to [] in values.yaml and the ConfigMap template rendered it directly with no way to override it via a top-level Helm value. This patch introduces a top-level watchNamespaces value and a new configmap-files helper that deep-copies configs.files, patches the nested watch.namespaces.include in-place, then delegates to the existing configmap-data helper for rendering. Fixes Altinity#1919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1919.
configs.files.config.yaml.watch.namespaces.includeis hardcoded to[]invalues.yamland the ConfigMap template renders it directly — there is no way to override it via a top-level Helm value. Users who need the operator to watch multiple namespaces must manually patch the ConfigMap after install, which is fragile and breaks on upgrades.Solution
This PR introduces:
watchNamespacesvalue invalues.yaml(empty by default — preserves existing behavior):A new
altinity-clickhouse-operator.configmap-fileshelper in_helpers.tplthat deep-copiesconfigs.files, patcheswatch.namespaces.includein-place, and delegates to the existingconfigmap-datahelper for rendering.The ConfigMap template updated to call the new helper instead of
configmap-datadirectly.Usage
Or via
--set:helm install clickhouse-operator altinity/altinity-clickhouse-operator \ --set "watchNamespaces={clickhouse-system,my-app-namespace}"Behavior
watchNamespaces: [](default) — no change, operator watches its own namespacewatchNamespaces: [".*"]— watch all namespacesTesting