Repository navigation
[OGUI-1926] Derive further UI state from models - #3644
Open
isaachilly wants to merge 2 commits into
Open
isaachilly wants to merge 2 commits into
isaachilly wants to merge 2 commits into
Conversation
isaachilly
added this pull request to stack #3645
September 29, 2026 12:35
isaachilly
force-pushed
the
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
branch
2 times, most recently
from
September 29, 2026 12:55
af5afb2 to
aaad543
Compare
isaachilly
changed the title
isaachilly
changed the title
isaachilly
force-pushed
the
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
branch
from
September 30, 2026 15:00
0b54150 to
f62dafb
Compare
Button style, live icon, browser tab title and auto-scroll were set inside the click handler via module-level state, so any mode change not triggered by a click left the UI stale. Derive them from log.activeMode in the model/view instead.
isaachilly
force-pushed
the
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
branch
from
October 13, 2026 13:23
a01f7e4 to
353a963
Compare
isaachilly
marked this pull request as ready for review
October 13, 2026 13:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Move model logic from view back into a model after noticing a lot in
commandLogs.Code:
activeMode.Loghelpers remove logic from thecommandLogsviewqueryliveStartetc now hide the download dropdown and set auto-scroll themselves. Logic that used to be in the view.frameworkInfomocks now have to includeinfoLogger-guias otherwise the tab title building will crash.Reviewer: