Skip to content

[OGUI-746] url parameter direct livemode - #2708

Draft
Houwie7000 wants to merge 1 commit into
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttonsfrom
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode
Draft

Houwie7000 wants to merge 1 commit into
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttonsfrom
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode

Conversation

@Houwie7000

@Houwie7000 Houwie7000 commented Jan 6, 2025 •

Copy link
Copy Markdown
Contributor

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

Ticket:

Accept a live URL parameter. When it is set to true, attempt to start live mode as soon as its dependencies have allow.

No mention if the live mode param should then be removed from the URL or stay and act as a shareable parameter.

Needed so the AliECS GUI can link from a running environment to InfoLogger GUI in live mode with autoscroll (OGUI-722).

Code:

Previously, the Query/Live mode switching and their button styling were handled in the commandLogs view by toggleButtonStates, which stored the button state in module-level variables. Starting live mode from the URL meant interacting with the view to update these variables, which prom[ted a refactor to extract logic from the view to a model.

  • Btn styling is derived from a lookup table based on activeMode.
  • Query/Live button click logic is moved into the Log model.
  • If parseLocation detects there is the live parameter it checks live mode's dependencies are available and moves to live mode. If the dependencies are not, it shows a danger notification.

Reviewer:

The reviewer can test using this URL (remove runNumber to match more logs, but this is the specific use case the ticket mentions):

http://localhost:8080/?q=%7B%22timestamp%22%3A%7B%22since%22%3A%22-1h%22%7D%2C%22run%22%3A%7B%22match%22%3A%22248025%22%7D%2C%22severity%22%3A%7B%22in%22%3A%22I%20W%20E%20F%22%7D%7D&live=true

@Houwie7000
Houwie7000 requested a review from graduta as a code owner January 6, 2025 09:28
@Houwie7000 Houwie7000 changed the title Improvement/houwie7000/og UI 746/url parameter direct livemode [OGUI-746] url parameter direct livemode Jan 6, 2025
@isaachilly
isaachilly self-requested a review as a code owner September 21, 2026 08:11
Comment thread InfoLogger/public/Model.js Fixed
@isaachilly isaachilly self-assigned this Sep 21, 2026
@isaachilly
isaachilly marked this pull request as draft September 21, 2026 16:32
@isaachilly
isaachilly changed the base branch from dev to improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons September 29, 2026 12:35
@isaachilly
isaachilly added this pull request to stack #3645 September 29, 2026 12:35
@isaachilly
isaachilly force-pushed the improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode branch from d1e5938 to 10200f9 Compare September 29, 2026 13:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants