Skip to content

[PWGLF] MC matching for kinkBuilder + SP process function for L1405#16484

Merged
mpuccio merged 12 commits into
AliceO2Group:masterfrom
Marcellocosti:master
Jun 4, 2026
Merged

[PWGLF] MC matching for kinkBuilder + SP process function for L1405#16484
mpuccio merged 12 commits into
AliceO2Group:masterfrom
Marcellocosti:master

Conversation

@Marcellocosti
Copy link
Copy Markdown
Contributor

@Marcellocosti Marcellocosti commented Jun 1, 2026 •
edited
Loading

  • kinkBuilder: added process function with Monte Carlo matching, histograms to study reconstruction efficiency, selection QA histograms and process function to analyze specific centrality intervals
  • lambda1405analysis: added process function with Scalar Product information, histograms for efficiency evaluation, possibility to analyze only a selected centrality class + QA histograms

Tagging @fmazzasc, @stefanopolitano

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026 •
edited
Loading

O2 linter results: ❌ 9 errors, ⚠️ 11 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Jun 1, 2026
Merged
Marcellocosti added a commit to Marcellocosti/O2Physics that referenced this pull request Jun 1, 2026
@Marcellocosti
Merge pull request #71 from alibuild/alibot-cleanup-16484
51bed22 
[PWGLF] Please consider the following formatting changes to AliceO2Group#16484
@alibuild alibuild mentioned this pull request Jun 2, 2026
Merged
@Marcellocosti Marcellocosti marked this pull request as ready for review June 2, 2026 04:27
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 2, 2026

Error while checking build/O2Physics/staging for 0ca9223 at 2026-06-02 08:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:831:43: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:842:48: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 2, 2026

Error while checking build/O2Physics/o2 for 0ca9223 at 2026-06-02 09:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:831:43: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:842:48: error: unused parameter 'mcGenCollisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Common/kinkBuilder.cxx:457:100: error: unused parameter 'collisions' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Jun 2, 2026
View reviewed changes
Comment thread PWGLF/Tasks/Resonances/lambda1405analysis.cxx Outdated
vkucera
vkucera reviewed Jun 2, 2026
View reviewed changes
Comment thread PWGLF/Tasks/Resonances/lambda1405analysis.cxx Outdated
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Jun 2, 2026

You are adding plenty of magic numbers. Don't.

@vkucera vkucera marked this pull request as draft June 2, 2026 14:24
@alibuild alibuild mentioned this pull request Jun 3, 2026
Merged
@Marcellocosti
Copy link
Copy Markdown
Contributor Author

Marcellocosti commented Jun 3, 2026

Thanks for your review @vkucera, I implemented your comments and fixed most of the warnings, which were although already present in the code

@Marcellocosti Marcellocosti marked this pull request as ready for review June 3, 2026 10:32
vkucera
vkucera reviewed Jun 3, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Common/kinkBuilder.cxx Outdated
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jun 4, 2026

Error while checking build/O2Physics/o2 for 81c6c75 at 2026-06-04 14:58:

[261/304] Linking CXX executable stage/bin/o2-analysis-em-tag-and-probe
[262/304] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-calib-task-emc.dir/calibTaskEmc.cxx.o
2026-06-04T14:57:46.297+0200 [4504:139826271846016] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[263/304] Linking CXX executable stage/bin/o2-analysis-em-material-budget
[264/304] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-non-lin-producer.dir/nonLinProducer.cxx.o
2026-06-04T14:57:46.954+0200 [4627:140162438516352] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[265/304] Linking CXX executable stage/bin/o2-analysis-em-material-budget-mc
[266/304] Linking CXX executable stage/bin/o2-analysis-em-pi0eta-to-gammagamma-mc-pcmdalitzee
[267/304] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-photon-reso-task.dir/photonResoTask.cxx.o
2026-06-04T14:57:46.445+0200 [4546:139742710632064] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[268/304] Linking CXX executable stage/bin/o2-analysis-em-task-flow-reso
[269/304] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-pm-qvector-dummy-otf.dir/pmQvectorDummyOtf.cxx.o
2026-06-04T14:57:47.171+0200 [4653:139622326591104] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[270/304] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-photonhbt.dir/photonhbt.cxx.o
2026-06-04T14:57:46.735+0200 [4588:140591894843008] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[271/304] Linking CXX executable stage/bin/o2-analysis-em-pi0-flow-emc
[272/304] Linking CXX executable stage/bin/o2-analysis-em-prefilter-photon
[273/304] Linking CXX executable stage/bin/o2-analysis-em-tagging-pi0-pcmdalitzee
[274/304] Linking CXX executable stage/bin/o2-analysis-em-test-task-emc
[275/304] Linking CXX executable stage/bin/o2-analysis-em-tagging-pi0-mc-pcmdalitzee
[276/304] Linking CXX executable stage/bin/o2-analysis-em-compconvbuilder
[277/304] Building CXX object PWGHF/HFL/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-single-muon-reader.dir/taskSingleMuonReader.cxx.o
2026-06-04T14:57:48.084+0200 [4726:140022279229056] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[278/304] Linking CXX executable stage/bin/o2-analysis-em-calib-task-emc
[279/304] Linking CXX executable stage/bin/o2-analysis-em-non-lin-producer
[280/304] Building CXX object EventFiltering/CMakeFiles/O2Physicsexe-analysis-em-photon-filter-qc.dir/PWGEM/EMPhotonFilterQC.cxx.o
2026-06-04T14:57:48.646+0200 [4824:139939047865984] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[281/304] Building CXX object EventFiltering/CMakeFiles/O2Physicsexe-analysis-em-photon-filter.dir/PWGEM/EMPhotonFilter.cxx.o
2026-06-04T14:57:48.579+0200 [4799:139730650594944] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[282/304] Linking CXX executable stage/bin/o2-analysis-em-photon-reso-task
[283/304] Building CXX object PWGHF/HFL/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-single-muon-reader-assoc.dir/taskSingleMuonReaderAssoc.cxx.o
2026-06-04T14:57:48.286+0200 [4756:140112490544768] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[284/304] Building CXX object EventFiltering/CMakeFiles/O2Physicsexe-analysis-heavy-neutral-meson-filter.dir/PWGEM/HeavyNeutralMesonFilter.cxx.o
2026-06-04T14:57:48.817+0200 [4852:140096928632448] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[285/304] Linking CXX executable stage/bin/o2-analysis-em-photonhbt
[286/304] Linking CXX executable stage/bin/o2-analysis-em-pm-qvector-dummy-otf
[287/304] Linking CXX executable stage/bin/o2-analysis-em-photon-filter
[288/304] Linking CXX executable stage/bin/o2-analysis-hf-task-single-muon-reader
[289/304] Linking CXX executable stage/bin/o2-analysis-heavy-neutral-meson-filter
[290/304] Linking CXX executable stage/bin/o2-analysis-em-photon-filter-qc
[291/304] Linking CXX executable stage/bin/o2-analysis-hf-task-single-muon-reader-assoc
[292/304] Building CXX object PWGLF/Tasks/Nuspex/CMakeFiles/O2Physicsexe-analysis-lf-kink-pika.dir/spectraKinkPiKa.cxx.o
2026-06-04T14:57:04.922+0200 [1139:140430663708288] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[293/304] Linking CXX executable stage/bin/o2-analysis-lf-kink-pika
[294/304] Building CXX object PWGLF/Tasks/Resonances/CMakeFiles/O2Physicsexe-analysis-lf-lambda1405analysis.dir/lambda1405analysis.cxx.o
2026-06-04T14:57:05.693+0200 [1182:139669744127616] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[295/304] Building CXX object PWGLF/TableProducer/Common/CMakeFiles/O2Physicsexe-analysis-lf-kink-builder.dir/kinkBuilder.cxx.o
2026-06-04T14:57:05.988+0200 [1249:140512013823616] [env.cpp:600] [WARNING] Warning: RECC_REMOTE_PLATFORM has no values.
[296/304] Linking CXX executable stage/bin/o2-analysis-lf-kink-builder
[297/304] Linking CXX executable stage/bin/o2-analysis-lf-lambda1405analysis

Full log here.

@mpuccio mpuccio merged commit 90c9cdf into AliceO2Group:master Jun 4, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@mpuccio mpuccio mpuccio approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marcellocosti @alibuild @vkucera @mpuccio