Skip to content

Avoid std::map in EventSelectionModule#16396

Open
ktf wants to merge 1 commit into
AliceO2Group:masterfrom
ktf:pr16396
Open

Avoid std::map in EventSelectionModule#16396
ktf wants to merge 1 commit into
AliceO2Group:masterfrom
ktf:pr16396

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented May 26, 2026

No description provided.

@ktf ktf requested review from a team, alibuild, ddobrigk, dsekihat, iarsene and jgrosseo as code owners May 26, 2026 12:22
@ktf
Copy link
Copy Markdown
Member Author

ktf commented May 26, 2026

@ddobrigk can you have a look here? Looking up in a map is very expensive due to the pointer traversal and constructing it requires one allocation per node which is also expensive. A binary search in a vector of pairs should be much faster. Also, @aalkin was suggesting to use a index table for this?

@ktf
Copy link
Copy Markdown
Member Author

ktf commented May 27, 2026

@ekryshen can you have a look at this?

@ekryshen
Copy link
Copy Markdown
Collaborator

@ktf Thanks, looks reasonable.

Actually I suspect that we don't need this map or vector of pairs any longer. It was introduced as a workaround for early passes of pp2022 where trigger info wasn't aligned with actual bcs. As far as I understand, the trigger functionality is used by EMCAL analysers only. I will check with them if they still need support of old passes. If not, we can simply remove this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants